public inbox for libc-stable@sourceware.org
 help / color / mirror / Atom feed
* [committed 2.36] get_nscd_addresses: Fix subscript typos [BZ #29605]
@ 2022-09-28 16:49 Siddhesh Poyarekar
  2022-09-30 13:20 ` FUCKETY FUCK FUCK FUCK - PLEASE FUCKING REMOVE ME> Darren Tristano
  0 siblings, 1 reply; 4+ messages in thread
From: Siddhesh Poyarekar @ 2022-09-28 16:49 UTC (permalink / raw)
  To: libc-stable; +Cc: Jörg Sonnenberger

From: Jörg Sonnenberger <joerg@bec.de>

Fix the subscript on air->family, which was accidentally set to COUNT
when it should have remained as I.

Resolves: BZ #29605

Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
(cherry picked from commit c9226c03da0276593a0918eaa9a14835183343e8)
---
 sysdeps/posix/getaddrinfo.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/sysdeps/posix/getaddrinfo.c b/sysdeps/posix/getaddrinfo.c
index bcff909b2f..5cda9bb072 100644
--- a/sysdeps/posix/getaddrinfo.c
+++ b/sysdeps/posix/getaddrinfo.c
@@ -540,11 +540,11 @@ get_nscd_addresses (const char *name, const struct addrinfo *req,
 	  at[count].addr[2] = htonl (0xffff);
 	}
       else if (req->ai_family == AF_UNSPEC
-	       || air->family[count] == req->ai_family)
+	       || air->family[i] == req->ai_family)
 	{
-	  at[count].family = air->family[count];
+	  at[count].family = air->family[i];
 	  memcpy (at[count].addr, addrs, size);
-	  if (air->family[count] == AF_INET6)
+	  if (air->family[i] == AF_INET6)
 	    res->got_ipv6 = true;
 	}
       at[count].next = at + count + 1;
-- 
2.37.2


^ permalink raw reply	[flat|nested] 4+ messages in thread

* FUCKETY FUCK FUCK FUCK - PLEASE FUCKING REMOVE ME>
  2022-09-28 16:49 [committed 2.36] get_nscd_addresses: Fix subscript typos [BZ #29605] Siddhesh Poyarekar
@ 2022-09-30 13:20 ` Darren Tristano
  0 siblings, 0 replies; 4+ messages in thread
From: Darren Tristano @ 2022-09-30 13:20 UTC (permalink / raw)
  To: libc-stable, Siddhesh Poyarekar; +Cc: Jörg Sonnenberger

[-- Attachment #1: Type: text/plain, Size: 2253 bytes --]

FUCKETY FUCK FUCK FUCK - PLEASE FUCKING REMOVE ME>FUCKETY FUCK FUCK FUCK - PLEASE FUCKING REMOVE ME>FUCKETY FUCK FUCK FUCK - PLEASE FUCKING REMOVE ME>FUCKETY FUCK FUCK FUCK - PLEASE FUCKING REMOVE ME>FUCKETY FUCK FUCK FUCK - PLEASE FUCKING REMOVE ME>FUCKETY FUCK FUCK FUCK - PLEASE FUCKING REMOVE ME>FUCKETY FUCK FUCK FUCK - PLEASE FUCKING REMOVE ME>FUCKETY FUCK FUCK FUCK - PLEASE FUCKING REMOVE ME>FUCKETY FUCK FUCK FUCK - PLEASE FUCKING REMOVE ME>FUCKETY FUCK FUCK FUCK - PLEASE FUCKING REMOVE ME>



Darren Tristano, CEO

FoodserviceResults

T: (708) 228-1427

darrentristano.com


________________________________
From: Libc-stable <libc-stable-bounces+darren=darrentristano.com@sourceware.org> on behalf of Siddhesh Poyarekar via Libc-stable <libc-stable@sourceware.org>
Sent: Wednesday, September 28, 2022 11:49 AM
To: libc-stable@sourceware.org <libc-stable@sourceware.org>
Cc: Jörg Sonnenberger <joerg@bec.de>
Subject: [committed 2.36] get_nscd_addresses: Fix subscript typos [BZ #29605]

From: Jörg Sonnenberger <joerg@bec.de>

Fix the subscript on air->family, which was accidentally set to COUNT
when it should have remained as I.

Resolves: BZ #29605

Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
(cherry picked from commit c9226c03da0276593a0918eaa9a14835183343e8)
---
 sysdeps/posix/getaddrinfo.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/sysdeps/posix/getaddrinfo.c b/sysdeps/posix/getaddrinfo.c
index bcff909b2f..5cda9bb072 100644
--- a/sysdeps/posix/getaddrinfo.c
+++ b/sysdeps/posix/getaddrinfo.c
@@ -540,11 +540,11 @@ get_nscd_addresses (const char *name, const struct addrinfo *req,
           at[count].addr[2] = htonl (0xffff);
         }
       else if (req->ai_family == AF_UNSPEC
-              || air->family[count] == req->ai_family)
+              || air->family[i] == req->ai_family)
         {
-         at[count].family = air->family[count];
+         at[count].family = air->family[i];
           memcpy (at[count].addr, addrs, size);
-         if (air->family[count] == AF_INET6)
+         if (air->family[i] == AF_INET6)
             res->got_ipv6 = true;
         }
       at[count].next = at + count + 1;
--
2.37.2


^ permalink raw reply	[flat|nested] 4+ messages in thread

* FUCKETY FUCK FUCK FUCK - PLEASE FUCKING REMOVE ME>
  2022-09-28 18:23         ` [PATCH v5 2/2] x86: Optimize strlen-avx2.S H.J. Lu
@ 2022-09-30 13:19           ` Darren Tristano
  0 siblings, 0 replies; 4+ messages in thread
From: Darren Tristano @ 2022-09-30 13:19 UTC (permalink / raw)
  To: Sunil Pandey, H.J. Lu; +Cc: GNU C Library, Libc-stable Mailing List

[-- Attachment #1: Type: text/plain, Size: 954 bytes --]

FUCKETY FUCK FUCK FUCK - PLEASE FUCKING REMOVE ME>



Darren Tristano, CEO

FoodserviceResults

T: (708) 228-1427

darrentristano.com


________________________________
From: Libc-stable <libc-stable-bounces+darren=darrentristano.com@sourceware.org> on behalf of H.J. Lu via Libc-stable <libc-stable@sourceware.org>
Sent: Wednesday, September 28, 2022 1:23 PM
To: Sunil Pandey <skpgkp2@gmail.com>
Cc: GNU C Library <libc-alpha@sourceware.org>; Libc-stable Mailing List <libc-stable@sourceware.org>
Subject: Re: [PATCH v5 2/2] x86: Optimize strlen-avx2.S

On Wed, Sep 28, 2022 at 6:55 AM Sunil Pandey <skpgkp2@gmail.com> wrote:
>
> Attached patch fixes BZ# 29611.
>
> I would like to backport it to 2.32,2.31,2.30,2.29 and 2.29. Let me know
> if there is any objection.

It doesn't fully fix BZ #29611.  Like Noah mentioned, we need to add
BMI2 check to ifunc-impl-list.c for all functions which use "ifunc-avx2.h".


H.J.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* FUCKETY FUCK FUCK FUCK - PLEASE FUCKING REMOVE ME>
  2022-09-28 18:24               ` H.J. Lu
@ 2022-09-30 13:19                 ` Darren Tristano
  0 siblings, 0 replies; 4+ messages in thread
From: Darren Tristano @ 2022-09-30 13:19 UTC (permalink / raw)
  To: Noah Goldstein, H.J. Lu
  Cc: GNU C Library, Sunil Pandey, Libc-stable Mailing List

[-- Attachment #1: Type: text/plain, Size: 1447 bytes --]

FUCKETY FUCK FUCK FUCK - PLEASE FUCKING REMOVE ME>




________________________________
From: Libc-stable <libc-stable-bounces+darren=darrentristano.com@sourceware.org> on behalf of H.J. Lu via Libc-stable <libc-stable@sourceware.org>
Sent: Wednesday, September 28, 2022 1:24 PM
To: Noah Goldstein <goldstein.w.n@gmail.com>
Cc: GNU C Library <libc-alpha@sourceware.org>; Sunil Pandey <skpgkp2@gmail.com>; Libc-stable Mailing List <libc-stable@sourceware.org>
Subject: Re: [PATCH v5 2/2] x86: Optimize strlen-avx2.S

On Wed, Sep 28, 2022 at 8:00 AM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
>
> On Wed, Sep 28, 2022 at 7:55 AM Sunil Pandey <skpgkp2@gmail.com> wrote:
> >
> > On Wed, Sep 28, 2022 at 7:42 AM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
> > >
> > > On Wed, Sep 28, 2022 at 6:55 AM Sunil Pandey <skpgkp2@gmail.com> wrote:
> > > >
> > > > Attached patch fixes BZ# 29611.
> > > >
> > > > I would like to backport it to 2.32,2.31,2.30,2.29 and 2.29. Let me know
> > > > if there is any objection.
> > > The ifunc-impl-list changes are missing BMI2 for memchr-avx2.S
> > >
> > > Can you post these as separate emails with the patches embedded instead of
> > > attached?
> > >
> > > >
> >
> > Patches are also posted on bug report 29611.
> >
> > https://sourceware.org/bugzilla/show_bug.cgi?id=29611
>
> is there a mailing list for backport patches like this?

It is libc-stable.

--
H.J.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-09-30 13:20 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-28 16:49 [committed 2.36] get_nscd_addresses: Fix subscript typos [BZ #29605] Siddhesh Poyarekar
2022-09-30 13:20 ` FUCKETY FUCK FUCK FUCK - PLEASE FUCKING REMOVE ME> Darren Tristano
     [not found] <20210419233607.916848-1-goldstein.w.n@gmail.com>
     [not found] ` <20210419233607.916848-2-goldstein.w.n@gmail.com>
     [not found]   ` <YzAO/ictPso/Y5LS@aurel32.net>
     [not found]     ` <CAFUsyf+U==grKgr9ZivEHDYsj=Xxi0MXBtQDfkU-JBHxb0pq+A@mail.gmail.com>
2022-09-28 13:54       ` [PATCH v5 2/2] x86: Optimize strlen-avx2.S Sunil Pandey
2022-09-28 14:42         ` Noah Goldstein
2022-09-28 14:54           ` Sunil Pandey
2022-09-28 15:00             ` Noah Goldstein
2022-09-28 18:24               ` H.J. Lu
2022-09-30 13:19                 ` FUCKETY FUCK FUCK FUCK - PLEASE FUCKING REMOVE ME> Darren Tristano
2022-09-28 18:23         ` [PATCH v5 2/2] x86: Optimize strlen-avx2.S H.J. Lu
2022-09-30 13:19           ` FUCKETY FUCK FUCK FUCK - PLEASE FUCKING REMOVE ME> Darren Tristano

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).