From: Stefan Liebler <stli@linux.ibm.com>
To: GNU C Library <libc-alpha@sourceware.org>, libc-stable@sourceware.org
Cc: "Carlos O'Donell" <carlos@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Sebastian Sewior <bigeasy@linutronix.de>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Torvald Riegel <triegel@redhat.com>,
Florian Weimer <fweimer@redhat.com>
Subject: [2.25 / 2.26 / 2.27 / 2.28 / 2.29 COMMITTED] Add compiler barriers around modifications of the robust mutex list for pthread_mutex_trylock. [BZ #24180]
Date: Tue, 01 Jan 2019 00:00:00 -0000 [thread overview]
Message-ID: <e480d714-75de-0861-f99f-8a7980e8a508@linux.ibm.com> (raw)
In-Reply-To: <466ae362-4d20-e911-6b20-f6c2be072c6d@redhat.com>
On 02/06/2019 04:59 PM, Carlos O'Donell wrote:
> On 2/6/19 6:25 AM, Stefan Liebler wrote:
>> Hi Carlos,
>> I've updated the patch with three additional comments and I've mentioned the filed bug.
>> Please review it once again before I commit it to master and cherry pick it to the release branches.
>
> Thank you! Reviewed.
Committed to master (2.29.9000):
"Add compiler barriers around modifications of the robust mutex list for
pthread_mutex_trylock. [BZ #24180]"
(https://sourceware.org/git/?p=glibc.git;a=commit;h=823624bdc47f1f80109c9c52dee7939b9386d708)
and backported it to glibc 2.25 ... 2.29 release branches.
Thanks.
Stefan
>
>>> Yes, I did that backport to RHEL 7.6. These fixes are just "further"
>>> fixes right? I'll work on getting this fixed in RHEL 7.7, and RHEL 8
>>> for all arches.
>> Sounds great.
>> That's the same fix for pthread_mutex_trylock as previously done for pthread_mutex_lock and pthread_mutex_timedlock.
>
> I've filed these:
> https://bugzilla.redhat.com/show_bug.cgi?id=1672771
> https://bugzilla.redhat.com/show_bug.cgi?id=1672773
>
> Feel free to comment or verify if they are going to be needed in RHEL7.7
> or RHEL8. I haven't done the analysis of the disassembly yet. If you
> could have a look that would help.
>
next parent reply other threads:[~2019-02-07 15:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <fcc30533-41b1-a159-7019-290d2c489242@linux.ibm.com>
[not found] ` <60ff0bf2-38f9-92b4-7582-8b65c2acfa0e@redhat.com>
[not found] ` <c60e8de1-704a-9ff1-6ec9-474e47cc4686@linux.ibm.com>
[not found] ` <466ae362-4d20-e911-6b20-f6c2be072c6d@redhat.com>
2019-01-01 0:00 ` Stefan Liebler [this message]
2019-01-01 0:00 ` Carlos O'Donell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e480d714-75de-0861-f99f-8a7980e8a508@linux.ibm.com \
--to=stli@linux.ibm.com \
--cc=bigeasy@linutronix.de \
--cc=carlos@redhat.com \
--cc=fweimer@redhat.com \
--cc=heiko.carstens@de.ibm.com \
--cc=libc-alpha@sourceware.org \
--cc=libc-stable@sourceware.org \
--cc=tglx@linutronix.de \
--cc=triegel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).