From: "James Greenhalgh" <james.greenhalgh@arm.com>
To: "James Greenhalgh" <James.Greenhalgh@arm.com>,
"'Anthony Green'" <green@moxielogic.com>
Cc: <libffi-discuss@sourceware.org>,
"Marcus Shawcroft" <Marcus.Shawcroft@arm.com>
Subject: RE: [libffi testsuite] Set -ffp-contract=off for libffi.call/many.c
Date: Tue, 25 Jun 2013 12:55:00 -0000 [thread overview]
Message-ID: <000001ce71a3$31a1fa70$94e5ef50$@greenhalgh@arm.com> (raw)
In-Reply-To: <009101ce5c48$0c657720$25306560$@greenhalgh@arm.com>
Hi Anthony,
Any thoughts on this?
Regards,
James
> > The problem with unqualified dg-options is that non-GCC compilers
> > will complain about them, and libffi currently supports compilers
> from
> > IBM, Oracle and Microsoft. Could you please resubmit with the
> > appropriate target qualifier? Just look at other uses of dg-options.
> > (to answer your other question, either a patch email or pull request
> > would be fine)
>
> Hi Anthony,
>
> I'm sorry, but I'm not sure what you are asking me to do. Looking at
> other test cases I see, for example:
>
> testsuite/libffi.call/huge_struct.c:/* { dg-options -Wformat=0 { target
moxie*-*-elf } } */
>
> But my understanding is that this restricts adding the option to
> moxie*-*-elf targets rather than compilers.
>
> I think to implement what you are asking I would want something like
>
> /* { dg-options -ffp-contract=off { compiler *gcc* } } */
>
> As best as I understand it, any GCC target which can contract
> fused multiply adds will require this change, which would require
> me to write:
>
> /* { dg-options -ffp-contract=off { target *-*-* } } */
>
> But then I think I have opened myself up to failing with other
> compilers
> again.
>
> Have I completely misunderstood what you are requesting? Could you
> point me towards some other examples which achieve what I want?
>
> Thanks,
> James
prev parent reply other threads:[~2013-06-25 12:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-08 9:37 James Greenhalgh
2013-04-19 10:01 ` James Greenhalgh
2013-05-09 12:59 ` James Greenhalgh
[not found] ` <CACxje5_Tp0an2rRwyUWKsqdE9vMOwDxfkSgGYTiankAH0bQLFQ@mail.gmail.com>
2013-05-29 8:39 ` James Greenhalgh
2013-06-25 12:55 ` James Greenhalgh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000001ce71a3$31a1fa70$94e5ef50$@greenhalgh@arm.com' \
--to=james.greenhalgh@arm.com \
--cc=Marcus.Shawcroft@arm.com \
--cc=green@moxielogic.com \
--cc=libffi-discuss@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).