public inbox for libffi-discuss@sourceware.org
 help / color / mirror / Atom feed
From: James Greenhalgh <james.greenhalgh@arm.com>
To: libffi-discuss@sourceware.org
Subject: [libffi testsuite] Set -ffp-contract=off for libffi.call/many.c
Date: Mon, 08 Apr 2013 09:37:00 -0000	[thread overview]
Message-ID: <1365413805-5517-1-git-send-email-james.greenhalgh@arm.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 895 bytes --]


Hi,

A recent patch fixed libffi.call/many.c to check that the absolute
value of the difference of its two test results was smaller than FLT_EPSILON,
rather than just checking their difference.

Sadly, this exposes a problem with the testcase for targets with
a fused-multiply-add instruction. After inlining the non-ffi function
body, GCC will happily contract the final multiply with the subtract
for the comparison. Thus skipping the rounding step after the multiply
and causing an error large enough to cause the test to fail.

Fixed by adding -ffp-contract=off to the list of dg-options thus
suppressing the introduction of fused-multiply-add.

Tested on aarch64-none-linux-gnu to ensure the failure becomes
a pass.

Thanks,
James Greenhalgh

---

2013-04-08  James Greenhalgh  <james.greenhalgh@arm.com>

	* testsuite/libffi.call/many.c: Set -ffp-contract=off.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-libffi-testsuite-Set-ffp-contract-off-for-libffi.cal.patch --]
[-- Type: text/x-patch;  name=0001-libffi-testsuite-Set-ffp-contract-off-for-libffi.cal.patch, Size: 358 bytes --]

diff --git a/testsuite/libffi.call/many.c b/testsuite/libffi.call/many.c
index 67a367f..afade91 100644
--- a/testsuite/libffi.call/many.c
+++ b/testsuite/libffi.call/many.c
@@ -5,6 +5,8 @@
    Originator:	From the original ffitest.c  */
 
 /* { dg-do run } */
+/* { dg-options -ffp-contract=off } */
+
 #include "ffitest.h"
 
 #include <stdlib.h>

             reply	other threads:[~2013-04-08  9:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-08  9:37 James Greenhalgh [this message]
2013-04-19 10:01 ` James Greenhalgh
2013-05-09 12:59   ` James Greenhalgh
     [not found] ` <CACxje5_Tp0an2rRwyUWKsqdE9vMOwDxfkSgGYTiankAH0bQLFQ@mail.gmail.com>
2013-05-29  8:39   ` James Greenhalgh
2013-06-25 12:55     ` James Greenhalgh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1365413805-5517-1-git-send-email-james.greenhalgh@arm.com \
    --to=james.greenhalgh@arm.com \
    --cc=libffi-discuss@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).