From: James Greenhalgh <james.greenhalgh@arm.com>
To: libffi-discuss@sourceware.org
Cc: marcus.shawcroft@arm.com, rth@redhat.com, green@moxielogic.com
Subject: [Patch AArch64] Add missing .note.GNU-stack note
Date: Thu, 13 Nov 2014 15:32:00 -0000 [thread overview]
Message-ID: <1415892722-14244-1-git-send-email-james.greenhalgh@arm.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 410 bytes --]
Hi Anthony,
This trivial patch fixes:
https://github.com/atgreen/libffi/issues/141
By adding a .note.GNU-stack note to the bottom of src/aarch64/sysv.S.
Tested native on aarch64-none-linux-gnu, with no issues in the testsuite.
Could you please apply this to HEAD?
Thanks,
James
---
2014-11-13 James Greenhalgh <james.greenhalgh@arm.com>
* aarch64/sysv.S: Add .note.GNU-stack.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Patch-AArch64-Add-missing-.note.GNU-stack-note.patch --]
[-- Type: text/x-patch; name=0001-Patch-AArch64-Add-missing-.note.GNU-stack-note.patch, Size: 388 bytes --]
diff --git a/src/aarch64/sysv.S b/src/aarch64/sysv.S
index 1fb68f2..d5b1c2e 100644
--- a/src/aarch64/sysv.S
+++ b/src/aarch64/sysv.S
@@ -396,3 +396,7 @@ CNAME(ffi_go_closure_SYSV):
.size CNAME(ffi_go_closure_SYSV), . - CNAME(ffi_go_closure_SYSV)
#endif
#endif /* FFI_GO_CLOSURES */
+
+#if defined __ELF__ && defined __linux__
+ .section .note.GNU-stack,"",%progbits
+#endif
next reply other threads:[~2014-11-13 15:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-13 15:32 James Greenhalgh [this message]
2014-11-21 17:30 ` James Greenhalgh
2014-12-05 17:33 ` James Greenhalgh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415892722-14244-1-git-send-email-james.greenhalgh@arm.com \
--to=james.greenhalgh@arm.com \
--cc=green@moxielogic.com \
--cc=libffi-discuss@sourceware.org \
--cc=marcus.shawcroft@arm.com \
--cc=rth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).