From: James Greenhalgh <james.greenhalgh@arm.com>
To: "libffi-discuss@sourceware.org" <libffi-discuss@sourceware.org>
Cc: Marcus Shawcroft <Marcus.Shawcroft@arm.com>,
"rth@redhat.com" <rth@redhat.com>,
"green@moxielogic.com" <green@moxielogic.com>
Subject: Re: [Patch AArch64] Add missing .note.GNU-stack note
Date: Fri, 21 Nov 2014 17:30:00 -0000 [thread overview]
Message-ID: <20141121173035.GA20263@arm.com> (raw)
In-Reply-To: <1415892722-14244-1-git-send-email-james.greenhalgh@arm.com>
*ping*
Thanks,
James
On Thu, Nov 13, 2014 at 03:32:02PM +0000, James Greenhalgh wrote:
>
> Hi Anthony,
>
> This trivial patch fixes:
> https://github.com/atgreen/libffi/issues/141
>
> By adding a .note.GNU-stack note to the bottom of src/aarch64/sysv.S.
>
> Tested native on aarch64-none-linux-gnu, with no issues in the testsuite.
>
> Could you please apply this to HEAD?
>
> Thanks,
> James
>
> ---
>
> 2014-11-13 James Greenhalgh <james.greenhalgh@arm.com>
>
> * aarch64/sysv.S: Add .note.GNU-stack.
>
> diff --git a/src/aarch64/sysv.S b/src/aarch64/sysv.S
> index 1fb68f2..d5b1c2e 100644
> --- a/src/aarch64/sysv.S
> +++ b/src/aarch64/sysv.S
> @@ -396,3 +396,7 @@ CNAME(ffi_go_closure_SYSV):
> .size CNAME(ffi_go_closure_SYSV), . - CNAME(ffi_go_closure_SYSV)
> #endif
> #endif /* FFI_GO_CLOSURES */
> +
> +#if defined __ELF__ && defined __linux__
> + .section .note.GNU-stack,"",%progbits
> +#endif
next prev parent reply other threads:[~2014-11-21 17:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-13 15:32 James Greenhalgh
2014-11-21 17:30 ` James Greenhalgh [this message]
2014-12-05 17:33 ` James Greenhalgh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141121173035.GA20263@arm.com \
--to=james.greenhalgh@arm.com \
--cc=Marcus.Shawcroft@arm.com \
--cc=green@moxielogic.com \
--cc=libffi-discuss@sourceware.org \
--cc=rth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).