From: Dominik Vogt <vogt@linux.vnet.ibm.com>
To: libffi-discuss@sourceware.org
Subject: Re: Fix powerpc breakage from 6e8a4460
Date: Mon, 10 Nov 2014 09:51:00 -0000 [thread overview]
Message-ID: <20141110095107.GA3657@linux.vnet.ibm.com> (raw)
In-Reply-To: <20141110042442.GH3990@bubble.grove.modra.org>
On Mon, Nov 10, 2014 at 02:54:42PM +1030, Alan Modra wrote:
> The addition of FFI_TYPE_COMPLEX broke powerpc libffi, showing up as
> four testsuite failures on powerpc64le. This fixes the breakage and
> ensures a more spectacular set of failures if something like this
> happens again.
>
> * src/powerpc/ffitarget.h: #error on unexpected FFI_TYPE_LAST.
...
> +/* ppc_closure.S and linux64_closure.S expect this. */
> +#define FFI_PPC_TYPE_LAST FFI_TYPE_POINTER
> +
> +/* We define additional types below. If generic types are added that
> + must be supported by powerpc libffi then it is likely that
> + FFI_PPC_TYPE_LAST needs increasing *and* the jump tables in
> + ppc_closure.S and linux64_closure.S be extended. */
Does this affect only powerpc? Is there any risk of breaking other
platforms too?
Ciao
Dominik ^_^ ^_^
--
Dominik Vogt
IBM Germany
next prev parent reply other threads:[~2014-11-10 9:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-10 4:24 Alan Modra
2014-11-10 9:51 ` Dominik Vogt [this message]
2014-11-11 13:19 ` Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141110095107.GA3657@linux.vnet.ibm.com \
--to=vogt@linux.vnet.ibm.com \
--cc=libffi-discuss@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).