public inbox for libffi-discuss@sourceware.org
 help / color / mirror / Atom feed
* Mark libffi as not requiring executable stack on FreeBSD
@ 2012-07-29  1:15 Konstantin Belousov
  2013-11-04 23:39 ` Brad Smith
  0 siblings, 1 reply; 2+ messages in thread
From: Konstantin Belousov @ 2012-07-29  1:15 UTC (permalink / raw)
  To: libffi-discuss

[-- Attachment #1: Type: text/plain, Size: 742 bytes --]

Hi,
libffi on FreeBSD uses assembler source src/x86/freebsd.S which lacks
.note.GNU-stack section. As result, libffi shared library and any code
that links with libffi statically ends up with executable stack.

Patch below fixes the issue. Please apply.

commit 2b8152f633c6debae0b6076b0c39eb326ceb09e2
Author: Konstantin Belousov <kib@freebsd.org>
Date:   Sun Jul 29 04:06:39 2012 +0300

    On FreeBSD, mark the assembler source as not requiring executable stack.

diff --git a/src/x86/freebsd.S b/src/x86/freebsd.S
index afde513..ee6fc45 100644
--- a/src/x86/freebsd.S
+++ b/src/x86/freebsd.S
@@ -456,3 +456,4 @@ ffi_closure_raw_SYSV:
 #endif
 
 #endif /* ifndef __x86_64__ */
+	.section .note.GNU-stack,"",%progbits

[-- Attachment #2: Type: application/pgp-signature, Size: 196 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Mark libffi as not requiring executable stack on FreeBSD
  2012-07-29  1:15 Mark libffi as not requiring executable stack on FreeBSD Konstantin Belousov
@ 2013-11-04 23:39 ` Brad Smith
  0 siblings, 0 replies; 2+ messages in thread
From: Brad Smith @ 2013-11-04 23:39 UTC (permalink / raw)
  To: libffi-discuss

On 28/07/12 9:14 PM, Konstantin Belousov wrote:
> Hi,
> libffi on FreeBSD uses assembler source src/x86/freebsd.S which lacks
> .note.GNU-stack section. As result, libffi shared library and any code
> that links with libffi statically ends up with executable stack.
>
> Patch below fixes the issue. Please apply.

ping.

> commit 2b8152f633c6debae0b6076b0c39eb326ceb09e2
> Author: Konstantin Belousov <kib-h+KGxgPPiopAfugRpC6u6w@public.gmane.org>
> Date:   Sun Jul 29 04:06:39 2012 +0300
>
>      On FreeBSD, mark the assembler source as not requiring executable stack.
>
> diff --git a/src/x86/freebsd.S b/src/x86/freebsd.S
> index afde513..ee6fc45 100644
> --- a/src/x86/freebsd.S
> +++ b/src/x86/freebsd.S
> @@ -456,3 +456,4 @@ ffi_closure_raw_SYSV:
>   #endif
>
>   #endif /* ifndef __x86_64__ */
> +	.section .note.GNU-stack,"",%progbits
>


-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-11-04 23:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-29  1:15 Mark libffi as not requiring executable stack on FreeBSD Konstantin Belousov
2013-11-04 23:39 ` Brad Smith

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).