From: Andrew Haley <aph@redhat.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: "Hogan, D. (GE Power & Water)" <D.Hogan@ge.com>,
"libffi-discuss@sourceware.org"
<libffi-discuss@sourceware.org>
Subject: Re: RFC: variadic closures in x86/x86_64
Date: Mon, 25 Nov 2013 10:10:00 -0000 [thread overview]
Message-ID: <5293221D.4010505@redhat.com> (raw)
In-Reply-To: <20131125093715.GU892@tucnak.redhat.com>
On 11/25/2013 09:37 AM, Jakub Jelinek wrote:
> On Mon, Nov 25, 2013 at 09:28:52AM +0000, Andrew Haley wrote:
>> On 11/25/2013 02:45 AM, Hogan, D. (GE Power & Water) wrote:
>>> I'm requesting feedback on an implementation of variadic closures in
>>> libffi. It currently supports x86 and x86_64. This change allows for
>>> FMI logging callbacks through JNA in the JFMI[1] and Ptolemy II[2]
>>> projects. The libffi changes are in a github branch[3].
>>
>> Why is this necessary? I thought that the variadic calling conventions
>> on x86 were the same as the non-variadic ones.
>
> On x86 they are, on x86_64 they are not (%rax register must contain the
> number of floating point varargs arguments AFAIK).
Sure, but we don't need a new libffi interface to do that. We need
only to set %rax. And we can just do that anyway; it doesn't hurt.
I must be missing something.
Andrew.
next prev parent reply other threads:[~2013-11-25 10:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-25 2:46 Hogan, D. (GE Power & Water)
2013-11-25 9:29 ` Andrew Haley
2013-11-25 9:37 ` Jakub Jelinek
2013-11-25 10:10 ` Andrew Haley [this message]
2013-11-26 14:27 ` Alan Modra
2013-12-04 8:03 ` Hogan, D. (GE Power & Water)
2013-12-04 11:05 ` Philip Ashmore
[not found] ` <F023C084BCC16446BDA5B664305741E8091E8B@ALPMBAPA05.e2k.ad.ge.com>
2013-12-05 13:03 ` Philip Ashmore
2013-12-04 12:21 ` Andrew Haley
2013-12-04 18:28 ` Hogan, D. (GE Power & Water)
2013-12-04 18:51 ` Andrew Haley
2013-12-05 0:47 ` Hogan, D. (GE Power & Water)
2013-12-05 8:33 ` Andrew Haley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5293221D.4010505@redhat.com \
--to=aph@redhat.com \
--cc=D.Hogan@ge.com \
--cc=jakub@redhat.com \
--cc=libffi-discuss@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).