* [PATCH, AArch64] Fix Call Frame Information in ffi_closure_SYSV
@ 2013-12-23 18:30 Yufeng Zhang
2014-01-06 12:36 ` Marcus Shawcroft
2014-01-14 12:10 ` [PING] " Yufeng Zhang
0 siblings, 2 replies; 6+ messages in thread
From: Yufeng Zhang @ 2013-12-23 18:30 UTC (permalink / raw)
To: libffi-discuss
[-- Attachment #1: Type: text/plain, Size: 329 bytes --]
Hi,
This patch fixes a bug in ./src/aarch64/sysv.S:ffi_closure_SYSV where
stack unwinding information was not generated correctly.
OK for the mainline?
Thanks,
Yufeng
2013-12-23 Yufeng Zhang <yufeng.zhang@arm.com>
* src/aarch64/sysv.S (ffi_closure_SYSV): Use x29 as the
main CFA reg; update cfi_rel_offset.
[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 882 bytes --]
diff --git a/src/aarch64/sysv.S b/src/aarch64/sysv.S
index 1022454..ecf6371 100644
--- a/src/aarch64/sysv.S
+++ b/src/aarch64/sysv.S
@@ -231,13 +231,13 @@ ffi_closure_SYSV:
cfi_rel_offset (x30, 8)
mov x29, sp
+ cfi_def_cfa_register (x29)
sub sp, sp, #ffi_closure_SYSV_FS
- cfi_adjust_cfa_offset (ffi_closure_SYSV_FS)
stp x21, x22, [x29, #-16]
- cfi_rel_offset (x21, 0)
- cfi_rel_offset (x22, 8)
+ cfi_rel_offset (x21, -16)
+ cfi_rel_offset (x22, -8)
/* Load x21 with &call_context. */
mov x21, sp
@@ -295,7 +295,7 @@ ffi_closure_SYSV:
cfi_restore (x22)
mov sp, x29
- cfi_adjust_cfa_offset (-ffi_closure_SYSV_FS)
+ cfi_def_cfa_register (sp)
ldp x29, x30, [sp], #16
cfi_adjust_cfa_offset (-16)
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH, AArch64] Fix Call Frame Information in ffi_closure_SYSV
2013-12-23 18:30 [PATCH, AArch64] Fix Call Frame Information in ffi_closure_SYSV Yufeng Zhang
@ 2014-01-06 12:36 ` Marcus Shawcroft
2014-01-14 12:10 ` [PING] " Yufeng Zhang
1 sibling, 0 replies; 6+ messages in thread
From: Marcus Shawcroft @ 2014-01-06 12:36 UTC (permalink / raw)
To: Yufeng Zhang; +Cc: libffi-discuss
On 23 December 2013 18:30, Yufeng Zhang <Yufeng.Zhang@arm.com> wrote:
> Hi,
>
> This patch fixes a bug in ./src/aarch64/sysv.S:ffi_closure_SYSV where stack
> unwinding information was not generated correctly.
>
> OK for the mainline?
This patch looks reasonable to me.
/Marcus
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PING] Re: [PATCH, AArch64] Fix Call Frame Information in ffi_closure_SYSV
2013-12-23 18:30 [PATCH, AArch64] Fix Call Frame Information in ffi_closure_SYSV Yufeng Zhang
2014-01-06 12:36 ` Marcus Shawcroft
@ 2014-01-14 12:10 ` Yufeng Zhang
2014-02-12 18:08 ` [PING^2] " Yufeng Zhang
2014-02-28 5:28 ` [PING] " Anthony Green
1 sibling, 2 replies; 6+ messages in thread
From: Yufeng Zhang @ 2014-01-14 12:10 UTC (permalink / raw)
To: libffi-discuss; +Cc: Marcus Shawcroft
Ping~
Originally posted it:
http://sourceware.org/ml/libffi-discuss/2013/msg00240.html
Thanks,
Yufeng
On 12/23/13 18:30, Yufeng Zhang wrote:
> Hi,
>
> This patch fixes a bug in ./src/aarch64/sysv.S:ffi_closure_SYSV where
> stack unwinding information was not generated correctly.
>
> OK for the mainline?
>
> Thanks,
> Yufeng
>
> 2013-12-23 Yufeng Zhang<yufeng.zhang@arm.com>
>
> * src/aarch64/sysv.S (ffi_closure_SYSV): Use x29 as the
> main CFA reg; update cfi_rel_offset.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PING^2] Re: [PATCH, AArch64] Fix Call Frame Information in ffi_closure_SYSV
2014-01-14 12:10 ` [PING] " Yufeng Zhang
@ 2014-02-12 18:08 ` Yufeng Zhang
2014-02-20 14:59 ` [PING^3] " Yufeng Zhang
2014-02-28 5:28 ` [PING] " Anthony Green
1 sibling, 1 reply; 6+ messages in thread
From: Yufeng Zhang @ 2014-02-12 18:08 UTC (permalink / raw)
To: libffi-discuss; +Cc: Marcus Shawcroft
Ping^2~~
Thanks,
Yufeng
On 01/14/14 12:10, Yufeng Zhang wrote:
> Ping~
>
> Originally posted it:
> http://sourceware.org/ml/libffi-discuss/2013/msg00240.html
>
> Thanks,
> Yufeng
>
> On 12/23/13 18:30, Yufeng Zhang wrote:
>> Hi,
>>
>> This patch fixes a bug in ./src/aarch64/sysv.S:ffi_closure_SYSV where
>> stack unwinding information was not generated correctly.
>>
>> OK for the mainline?
>>
>> Thanks,
>> Yufeng
>>
>> 2013-12-23 Yufeng Zhang<yufeng.zhang@arm.com>
>>
>> * src/aarch64/sysv.S (ffi_closure_SYSV): Use x29 as the
>> main CFA reg; update cfi_rel_offset.
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PING^3] Re: [PATCH, AArch64] Fix Call Frame Information in ffi_closure_SYSV
2014-02-12 18:08 ` [PING^2] " Yufeng Zhang
@ 2014-02-20 14:59 ` Yufeng Zhang
0 siblings, 0 replies; 6+ messages in thread
From: Yufeng Zhang @ 2014-02-20 14:59 UTC (permalink / raw)
To: libffi-discuss; +Cc: green, Marcus Shawcroft, gcc-patches
Ping^3~~~
Is there a way in getting attention from libffi maintainers? I really
would like to see the patch made into gcc before the stage 4 closes.
Thanks,
Yufeng
On 02/12/14 18:08, Yufeng Zhang wrote:
> Ping^2~~
>
> Thanks,
> Yufeng
>
> On 01/14/14 12:10, Yufeng Zhang wrote:
>> Ping~
>>
>> Originally posted it:
>> http://sourceware.org/ml/libffi-discuss/2013/msg00240.html
>>
>> Thanks,
>> Yufeng
>>
>> On 12/23/13 18:30, Yufeng Zhang wrote:
>>> Hi,
>>>
>>> This patch fixes a bug in ./src/aarch64/sysv.S:ffi_closure_SYSV where
>>> stack unwinding information was not generated correctly.
>>>
>>> OK for the mainline?
>>>
>>> Thanks,
>>> Yufeng
>>>
>>> 2013-12-23 Yufeng Zhang<yufeng.zhang@arm.com>
>>>
>>> * src/aarch64/sysv.S (ffi_closure_SYSV): Use x29 as the
>>> main CFA reg; update cfi_rel_offset.
>>
>>
>>
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PING] Re: [PATCH, AArch64] Fix Call Frame Information in ffi_closure_SYSV
2014-01-14 12:10 ` [PING] " Yufeng Zhang
2014-02-12 18:08 ` [PING^2] " Yufeng Zhang
@ 2014-02-28 5:28 ` Anthony Green
1 sibling, 0 replies; 6+ messages in thread
From: Anthony Green @ 2014-02-28 5:28 UTC (permalink / raw)
To: Yufeng Zhang; +Cc: libffi-discuss, Marcus Shawcroft
Yufeng Zhang <Yufeng.Zhang@arm.com> writes:
> Ping~
>
> Originally posted it:
> http://sourceware.org/ml/libffi-discuss/2013/msg00240.html
Thanks Yufeng!
AG
>
> Thanks,
> Yufeng
>
> On 12/23/13 18:30, Yufeng Zhang wrote:
>> Hi,
>>
>> This patch fixes a bug in ./src/aarch64/sysv.S:ffi_closure_SYSV where
>> stack unwinding information was not generated correctly.
>>
>> OK for the mainline?
>>
>> Thanks,
>> Yufeng
>>
>> 2013-12-23 Yufeng Zhang<yufeng.zhang@arm.com>
>>
>> * src/aarch64/sysv.S (ffi_closure_SYSV): Use x29 as the
>> main CFA reg; update cfi_rel_offset.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-02-28 5:28 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-12-23 18:30 [PATCH, AArch64] Fix Call Frame Information in ffi_closure_SYSV Yufeng Zhang
2014-01-06 12:36 ` Marcus Shawcroft
2014-01-14 12:10 ` [PING] " Yufeng Zhang
2014-02-12 18:08 ` [PING^2] " Yufeng Zhang
2014-02-20 14:59 ` [PING^3] " Yufeng Zhang
2014-02-28 5:28 ` [PING] " Anthony Green
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).