From: Samuli Suominen <ssuominen@gentoo.org>
To: libffi-discuss@sourceware.org
Subject: [patch] libffi.so.6 in libffi-3.1 is built with execstacks because of missing GNU stack marking in win32.S
Date: Wed, 28 May 2014 13:33:00 -0000 [thread overview]
Message-ID: <5385E51A.8030000@gentoo.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 591 bytes --]
Downstream report you should read,
http://bugs.gentoo.org/show_bug.cgi?id=511634
Basically Makefile's are always including src/x86/win32.S even on a
non-windows system, and win32.S is missing the GNU stack
marking other files already have:
Makefile.am has:
if X86
nodist_libffi_la_SOURCES += src/x86/ffi.c src/x86/sysv.S src/x86/win32.S
endif
and it doesn't have the
#if defined __ELF__ && defined __linux__
.section .note.GNU-stack,"",@progbits
#endif
other files like sysv.S, unix64.S, freebsd.S, already have
The attached patch fixes the executable stack in libffi.so.6
[-- Attachment #2: libffi-3.1-execstack.patch --]
[-- Type: text/x-patch, Size: 218 bytes --]
http://bugs.gentoo.org/511634
--- src/x86/win32.S
+++ src/x86/win32.S
@@ -1304,3 +1304,6 @@
#endif /* !_MSC_VER */
+#if defined __ELF__ && defined __linux__
+ .section .note.GNU-stack,"",@progbits
+#endif
reply other threads:[~2014-05-28 13:33 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5385E51A.8030000@gentoo.org \
--to=ssuominen@gentoo.org \
--cc=libffi-discuss@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).