public inbox for libffi-discuss@sourceware.org
 help / color / mirror / Atom feed
* [patch] libffi.so.6 in libffi-3.1 is built with execstacks because of missing GNU stack marking in win32.S
@ 2014-05-28 13:33 Samuli Suominen
  0 siblings, 0 replies; only message in thread
From: Samuli Suominen @ 2014-05-28 13:33 UTC (permalink / raw)
  To: libffi-discuss

[-- Attachment #1: Type: text/plain, Size: 591 bytes --]

Downstream report you should read,
http://bugs.gentoo.org/show_bug.cgi?id=511634

Basically Makefile's are always including src/x86/win32.S even on a
non-windows system, and win32.S is missing the GNU stack
marking other files already have:

Makefile.am has:

if X86
nodist_libffi_la_SOURCES += src/x86/ffi.c src/x86/sysv.S src/x86/win32.S
endif

and it doesn't have the

#if defined __ELF__ && defined __linux__
    .section        .note.GNU-stack,"",@progbits
#endif

other files like sysv.S, unix64.S, freebsd.S, already have

The attached patch fixes the executable stack in libffi.so.6

[-- Attachment #2: libffi-3.1-execstack.patch --]
[-- Type: text/x-patch, Size: 218 bytes --]

http://bugs.gentoo.org/511634

--- src/x86/win32.S
+++ src/x86/win32.S
@@ -1304,3 +1304,6 @@
 
 #endif /* !_MSC_VER */
 
+#if defined __ELF__ && defined __linux__
+	.section        .note.GNU-stack,"",@progbits
+#endif

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2014-05-28 13:33 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-28 13:33 [patch] libffi.so.6 in libffi-3.1 is built with execstacks because of missing GNU stack marking in win32.S Samuli Suominen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).