From: Kyrill Tkachov <kyrylo.tkachov@foss.arm.com>
To: Saleem Abdulrasool <compnerd@compnerd.org>,
libffi-discuss@sourceware.org
Subject: Re: armhf testsuite failures possibly due to 7ad0ae7f42
Date: Wed, 25 Oct 2017 08:15:00 -0000 [thread overview]
Message-ID: <59F04802.8050703@foss.arm.com> (raw)
In-Reply-To: <CANXyDxtDxEHr_teZ6xxQVek8o9ONTG7HyMz1RpqmSVJwuM7sBw@mail.gmail.com>
On 25/10/17 01:20, Saleem Abdulrasool wrote:
> Hey, it was a silly bug caused by a level of indirection thing. I
> sent a PR (381) on github to address the issue. It passes the tests
> locally.
>
Thanks for looking into it!
Kyrill
> On Mon, Oct 23, 2017 at 5:35 PM Saleem Abdulrasool
> <compnerd@compnerd.org <mailto:compnerd@compnerd.org>> wrote:
>
> On Mon, Oct 23, 2017 at 2:53 AM Kyrill Tkachov
> <kyrylo.tkachov@foss.arm.com <mailto:kyrylo.tkachov@foss.arm.com>>
> wrote:
>
> Hi all,
>
> Matthias' testing of libffi [1] (thanks!) shows some recent
> failures on
> armhf relating to closures with short types
> (search for "FAIL:")
>
> Considering that the results from May look okay I suspect the
> culprit is
> commit 7ad0ae7f42f3e208431ab66a9032dc9549f978d0 (arm: zext
> return value
> parameters)
> from Oct 10.
> Would it be possible to take a look and fix the failures?
>
>
> Thanks for the notification.
>
> Yeah, the tests probably need to be adjusted. The tests look like
> something which would be impacted by the zext. It was previously
> sending whatever was in the register previously.
>
>
> Thanks,
> Kyrill
>
> (Please keep me on CC to any replies as I am not subscribed to
> this list)
>
> [1]
> https://buildd.debian.org/status/fetch.php?pkg=libffi&arch=armhf&ver=3.3~20171020-1&stamp=1508524302&raw=0
> <https://buildd.debian.org/status/fetch.php?pkg=libffi&arch=armhf&ver=3.3%7E20171020-1&stamp=1508524302&raw=0>
>
> [2]
> https://buildd.debian.org/status/fetch.php?pkg=libffi&arch=armhf&ver=3.3~20170512-1&stamp=1494644748&raw=0
> <https://buildd.debian.org/status/fetch.php?pkg=libffi&arch=armhf&ver=3.3%7E20170512-1&stamp=1494644748&raw=0>
>
> --
> Saleem Abdulrasool
> compnerd (at) compnerd (dot) org
>
> --
> Saleem Abdulrasool
> compnerd (at) compnerd (dot) org
prev parent reply other threads:[~2017-10-25 8:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-23 9:53 Kyrill Tkachov
2017-10-24 0:35 ` Saleem Abdulrasool
2017-10-25 0:20 ` Saleem Abdulrasool
2017-10-25 8:15 ` Kyrill Tkachov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59F04802.8050703@foss.arm.com \
--to=kyrylo.tkachov@foss.arm.com \
--cc=compnerd@compnerd.org \
--cc=libffi-discuss@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).