Re: libffi 3.1-rc1 needs testing!

[Anthony Green <green@moxielogic.com>]

James Greenhalgh <james.greenhalgh@arm.com> writes:

> Hi,
>
> I'm seeing issues with libffi.call/float2.c on GCC 4.9 toolchains across
> ARM, AArch64, x86_64. I guess GCC 4.9 is more aggressive in warning for
> unused values:

Thanks James.  I just committed a fix for this.

AG




>
> FAIL: libffi.call/float2.c -W -Wall -O0 (test for excess errors)
> FAIL: libffi.call/float2.c -W -Wall -O2 (test for excess errors)
> FAIL: libffi.call/float2.c -W -Wall -O3 (test for excess errors)
> FAIL: libffi.call/float2.c -W -Wall -Os (test for excess errors)
> FAIL: libffi.call/float2.c -W -Wall -O2 -fomit-frame-pointer (test for excess errors)
>
> In file included from ../../testsuite/libffi.call/float2.c:10:0:
> ../../testsuite/libffi.call/float2.c: In function 'main':
> ../../testsuite/libffi.call/ffitest.h:18:39: warning: right-hand operand of comma expression has no effect [-Wunused-value]
>  #define CHECK(x) (!(x) ? (abort(), 1) : 0)
>                                        ^
> ../../testsuite/libffi.call/float2.c:55:5: note: in expansion of macro 'CHECK'
>      CHECK(0);
>      ^
> output is:
> In file included from ../../testsuite/libffi.call/float2.c:10:0:
> ../../testsuite/libffi.call/float2.c: In function 'main':
> ../../testsuite/libffi.call/ffitest.h:18:39: warning: right-hand operand of comma expression has no effect [-Wunused-value]
>  #define CHECK(x) (!(x) ? (abort(), 1) : 0)
>                                        ^
> ../../testsuite/libffi.call/float2.c:55:5: note: in expansion of macro 'CHECK'
>      CHECK(0);
>      ^
>
> Thanks,
> James