Re: libffi 3.1-rc1 needs testing!

[Marcus Shawcroft <marcus.shawcroft@gmail.com>]

On 28 March 2014 17:33, Anthony Green <green@moxielogic.com> wrote:
> James Greenhalgh <james.greenhalgh@arm.com> writes:
>
>> Hi,
>>
>> I'm seeing issues with libffi.call/float2.c on GCC 4.9 toolchains across
>> ARM, AArch64, x86_64. I guess GCC 4.9 is more aggressive in warning for
>> unused values:
>
> Thanks James.  I just committed a fix for this.
>
> AG

>> FAIL: libffi.call/float2.c -W -Wall -O0 (test for excess errors)
>> FAIL: libffi.call/float2.c -W -Wall -O2 (test for excess errors)
>> FAIL: libffi.call/float2.c -W -Wall -O3 (test for excess errors)
>> FAIL: libffi.call/float2.c -W -Wall -Os (test for excess errors)
>> FAIL: libffi.call/float2.c -W -Wall -O2 -fomit-frame-pointer (test for excess errors)
>>
>> In file included from ../../testsuite/libffi.call/float2.c:10:0:
>> ../../testsuite/libffi.call/float2.c: In function 'main':
>> ../../testsuite/libffi.call/ffitest.h:18:39: warning: right-hand operand of comma expression has no effect [-Wunused-value]
>>  #define CHECK(x) (!(x) ? (abort(), 1) : 0)
>>                                        ^
>> ../../testsuite/libffi.call/float2.c:55:5: note: in expansion of macro 'CHECK'
>>      CHECK(0);
>>      ^
>> output is:
>> In file included from ../../testsuite/libffi.call/float2.c:10:0:
>> ../../testsuite/libffi.call/float2.c: In function 'main':
>> ../../testsuite/libffi.call/ffitest.h:18:39: warning: right-hand operand of comma expression has no effect [-Wunused-value]
>>  #define CHECK(x) (!(x) ? (abort(), 1) : 0)
>>                                        ^
>> ../../testsuite/libffi.call/float2.c:55:5: note: in expansion of macro 'CHECK'
>>      CHECK(0);
>>      ^


Hi Anthony, I'm still seeing these failures on master. I'm currently
looking at version:

commit 31e0d4ecff6dc2a6c75a066ee099b52a43f6ba27
Merge: 1c0e9a7 99909eb
Author: Anthony Green <green@moxielogic.com>
Date:   Wed Apr 23 19:24:47 2014 -0400

did the fix you applied make it to master?

Cheers
/Marcus