From: Anthony Green <green@moxielogic.com>
To: Matthias Klose <doko@ubuntu.com>
Cc: "libffi-discuss\@sourceware.org" <libffi-discuss@sourceware.org>
Subject: Re: [patch] fix build error with -Werror=declaration-after-statement
Date: Sat, 20 Sep 2014 10:37:00 -0000 [thread overview]
Message-ID: <87tx42h91u.fsf@moxielogic.com> (raw)
In-Reply-To: <53E76EA8.5000804@ubuntu.com> (Matthias Klose's message of "Sun, 10 Aug 2014 15:07:52 +0200")
Matthias Klose <doko@ubuntu.com> writes:
> seen while merging the 3.1 release into the python sources. The build fails when
> built with -Werror=declaration-after-statement
Thanks, Matthias. Committed.
>
> Matthias
>
> diff -urN libffi-3.1/src/arm/ffi.c libffi/src/arm/ffi.c
> --- libffi-3.1/src/arm/ffi.c Sat Aug 09 23:52:34 2014 +0200
> +++ libffi/src/arm/ffi.c Sat Aug 09 23:58:38 2014 +0200
> @@ -154,9 +154,6 @@
>
> int ffi_prep_args_VFP(char *stack, extended_cif *ecif, float *vfp_space)
> {
> - // make sure we are using FFI_VFP
> - FFI_ASSERT(ecif->cif->abi == FFI_VFP);
> -
> register unsigned int i, vi = 0;
> register void **p_argv;
> register char *argp, *regp, *eo_regp;
> @@ -165,6 +162,9 @@
> char done_with_regs = 0;
> char is_vfp_type;
>
> + // make sure we are using FFI_VFP
> + FFI_ASSERT(ecif->cif->abi == FFI_VFP);
> +
> /* the first 4 words on the stack are used for values passed in core
> * registers. */
> regp = stack;
prev parent reply other threads:[~2014-09-20 10:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-10 13:08 Matthias Klose
2014-09-20 10:37 ` Anthony Green [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tx42h91u.fsf@moxielogic.com \
--to=green@moxielogic.com \
--cc=doko@ubuntu.com \
--cc=libffi-discuss@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).