public inbox for libffi-discuss@sourceware.org
 help / color / mirror / Atom feed
From: "Kaz Kylheku (libffi)" <382-725-6798@kylheku.com>
To: Anthony Green <green@moxielogic.com>
Cc: Matthias Klose <doko@debian.org>,
	libffi-discuss@sourceware.org, "H.J. Lu" <hjl.tools@gmail.com>
Subject: Re: libffi trunk: new regressions on x86_64-linux-gnu, some test failures left on i686-linux-gnu
Date: Sat, 05 May 2018 14:36:00 -0000	[thread overview]
Message-ID: <95c5ed34fcb8394f33e67ac6f65a3cce@mail.kylheku.com> (raw)
In-Reply-To: <CACxje59LJNox2njhcegGEKzMvphrRWn4DEc2Gd6LUkbMM7oNJw@mail.gmail.com>

On 2018-05-05 06:51, Anthony Green wrote:
> These failures are showing up because we're testing the microsoft ABI 
> now.
> 
> This looks like a bug in GCC.  It's not returning small structures with
> floating point values in the right registers when following the 
> Microsoft
> ABI.  I'm going to figure out how to 'xfail' those tests and open a bug
> against GCC.   Clang appears to get it right.

When would this be an actual issue?

What function in what Windows DLL returns a structure with 
floating-point values, and is that Windows DLL compiled with GCC so that 
the return representation is wrong? Cygwin code, maybe?

It the situation broken, or is it consistent? I mean, can a test case be 
written for GCC which shows that the structure return is corrupted, when 
both the caller and callee are compiled with the same GCC and same ABI? 
Or does the calling code match the return conventions?

If things are consistent, then fixing it in GCC requires versioning of 
some sort. If someone upgrades GCC to the fix and then recompiles only 
the caller of such a function, or only the callee, the now mismatching 
call will misbehave.

In a distro, if program P depends on library L, usually we can update P 
independently of L. If the compiler used for P has changed, this is no 
longer the case; the new P has an ABI change which has to pull in a new 
L. (At least, if the ABI change is relevant to P-L; who is going to 
check that for all packages?)

  reply	other threads:[~2018-05-05 14:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-05 13:39 Matthias Klose
2018-05-05 13:52 ` Anthony Green
2018-05-05 14:36   ` Kaz Kylheku (libffi) [this message]
2018-05-06  1:31     ` Anthony Green
2018-05-06  1:31       ` Anthony Green
2018-05-05 13:52 ` H.J. Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=95c5ed34fcb8394f33e67ac6f65a3cce@mail.kylheku.com \
    --to=382-725-6798@kylheku.com \
    --cc=doko@debian.org \
    --cc=green@moxielogic.com \
    --cc=hjl.tools@gmail.com \
    --cc=libffi-discuss@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).