From: Anthony Green <green@moxielogic.com>
To: "Kaz Kylheku (libffi)" <382-725-6798@kylheku.com>
Cc: Matthias Klose <doko@debian.org>,
libffi-discuss@sourceware.org, "H.J. Lu" <hjl.tools@gmail.com>
Subject: Re: libffi trunk: new regressions on x86_64-linux-gnu, some test failures left on i686-linux-gnu
Date: Sun, 06 May 2018 01:31:00 -0000 [thread overview]
Message-ID: <CACxje59=5s9D+fQk4=ACARx+RF-Ng2ZxQNwqr-3hC7s7ZfZoZQ@mail.gmail.com> (raw)
In-Reply-To: <95c5ed34fcb8394f33e67ac6f65a3cce@mail.kylheku.com>
On Sat, May 5, 2018 at 10:36 AM, Kaz Kylheku (libffi) <
382-725-6798@kylheku.com> wrote:
> On 2018-05-05 06:51, Anthony Green wrote:
>
>> These failures are showing up because we're testing the microsoft ABI now.
>>
>> This looks like a bug in GCC. It's not returning small structures with
>> floating point values in the right registers when following the Microsoft
>> ABI. I'm going to figure out how to 'xfail' those tests and open a bug
>> against GCC. Clang appears to get it right.
>>
>
> When would this be an actual issue?
>
As far as I know this is the first time this bug has been reported. I've
filed it here: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=43869
GCC is internally consistant, but can't generate code that will interface
correctly to binaries built with clang or visual c.
Since nobody has reported this problem before, I'm OK with having libffi
follow the correct ABI as long as the GCC hackers agree to fix this in
future versions of GCC. Libffi won't work with GCC-compiled ms_abi
functions returning short structs (8 bytes or less) containing floating
point values (a pretty narrow use-case!). This is why I'll just xfail the
problematic test cases when we know we're using GCC.
AG
next prev parent reply other threads:[~2018-05-06 1:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-05 13:39 Matthias Klose
2018-05-05 13:52 ` H.J. Lu
2018-05-05 13:52 ` Anthony Green
2018-05-05 14:36 ` Kaz Kylheku (libffi)
2018-05-06 1:31 ` Anthony Green [this message]
2018-05-06 1:31 ` Anthony Green
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACxje59=5s9D+fQk4=ACARx+RF-Ng2ZxQNwqr-3hC7s7ZfZoZQ@mail.gmail.com' \
--to=green@moxielogic.com \
--cc=382-725-6798@kylheku.com \
--cc=doko@debian.org \
--cc=hjl.tools@gmail.com \
--cc=libffi-discuss@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).