public inbox for libffi-discuss@sourceware.org
 help / color / mirror / Atom feed
From: Andrew Pinski <pinskia@gmail.com>
To: Richard Henderson <rth@redhat.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
		"libffi-discuss@sourceware.org" <libffi-discuss@sourceware.org>
Subject: Re: [PATCH] Implement libffi for AARCH64:ILP32
Date: Tue, 10 Feb 2015 19:02:00 -0000	[thread overview]
Message-ID: <CA+=Sn1=Urso0f5c_3KUH5OnwPTJO2ir6qaGkncTB+eroqBZidQ@mail.gmail.com> (raw)
In-Reply-To: <54DA4F85.70606@redhat.com>

On Tue, Feb 10, 2015 at 10:35 AM, Richard Henderson <rth@redhat.com> wrote:
> On 02/09/2015 12:40 AM, Andrew Pinski wrote:
>>  #ifndef LIBFFI_ASM
>> +#ifdef __ILP32__
>> +typedef unsigned long long ffi_arg;
>> +typedef signed long long ffi_sarg;
>> +#else
>
> You need to set FFI_SIZEOF_ARG too.
>
> Otherwise it looks ok.

Thanks.  I am testing the patch with the following added under the ILP32 check:
+#define FFI_SIZEOF_ARG 8
+#define FFI_SIZEOF_JAVA_RAW  4


Thanks,
Andrew Pinski


>
>
> r~

  reply	other threads:[~2015-02-10 19:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-09  8:40 Andrew Pinski
2015-02-09  8:51 ` Andrew Haley
2015-02-10 18:40   ` Richard Henderson
2015-02-10 18:35 ` Richard Henderson
2015-02-10 19:02   ` Andrew Pinski [this message]
2015-02-10 21:20     ` Richard Henderson
2015-02-10 22:46       ` Andrew Pinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+=Sn1=Urso0f5c_3KUH5OnwPTJO2ir6qaGkncTB+eroqBZidQ@mail.gmail.com' \
    --to=pinskia@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=libffi-discuss@sourceware.org \
    --cc=rth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).