From: David Edelsohn <dje.gcc@gmail.com>
To: GCC Patches <gcc-patches@gcc.gnu.org>,
libffi-discuss@sourceware.org, Alan Modra <amodra@gmail.com>
Subject: Re: [RS6000] libffi little-endian
Date: Mon, 24 Jun 2013 02:32:00 -0000 [thread overview]
Message-ID: <CAGWvnynaBOpwBXdytHXtESC1HjVJDqKd0Xac71ixObzgeOM74A@mail.gmail.com> (raw)
In-Reply-To: <20130624002616.GG21523@bubble.grove.modra.org>
On Sun, Jun 23, 2013 at 8:26 PM, Alan Modra <amodra@gmail.com> wrote:
> On Fri, Jun 07, 2013 at 12:12:17AM -0400, David Edelsohn wrote:
>> On Thu, Jun 6, 2013 at 9:34 PM, Alan Modra <amodra@gmail.com> wrote:
>> > Bootstrapped and regression tested powerpc64-linux. OK to apply?
>> >
>> > * src/powerpc/linux64_closure.S (ffi_closure_LINUX64): Support
>> > little-endian.
>> > * src/powerpc/ppc_closure.S (ffi_closure_SYSV): Likewise.
>>
>> This patch needs to be applied upstream in the libffi repository.
>>
>> All of the handling of structs in ffi.c and ffi_darwin.c doesn't need
>> any changes? Cool. I thought there might be a padding issue.
>
> You were right, of course. When we finally got around to running an
> all languages bootstrap on powerpc64le, we discovered some missing
> pieces in libffi. The following adds some ffi.c changes to the
> previous patch (closure.S patches are unchanged). I haven't tackled
> ffi_darwin.c.
>
> Bootstrapped and regression tested powerpc64-linux. This one passes
> the libffi testsuite on powerpc64le-linux. OK mainline and 4.8?
>
> * src/powerpc/ffi.c (ffi_prep_args_SYSV): Move var declaration
> before statements.
> (ffi_prep_args64): Support little-endian.
> (ffi_closure_helper_SYSV, ffi_closure_helper_LINUX64): Likewise.
> * src/powerpc/linux64_closure.S (ffi_closure_LINUX64): Likewise.
> * src/powerpc/ppc_closure.S (ffi_closure_SYSV): Likewise.
This looks okay to me and more like the changes I expected. Assuming
Anthony accepts it upstream.
Thanks, David
next prev parent reply other threads:[~2013-06-24 2:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20130607013408.GI6878@bubble.grove.modra.org>
[not found] ` <CAGWvnynZsHaM+EaHQMOTiQKb6Pg5gT4OY8B1ZtwLEV+iGih7bw@mail.gmail.com>
2013-06-24 0:26 ` Alan Modra
2013-06-24 2:32 ` David Edelsohn [this message]
2013-06-24 15:12 ` Anthony Green
2013-06-25 0:11 ` Alan Modra
2013-06-07 10:28 Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGWvnynaBOpwBXdytHXtESC1HjVJDqKd0Xac71ixObzgeOM74A@mail.gmail.com \
--to=dje.gcc@gmail.com \
--cc=amodra@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libffi-discuss@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).