From: Ian Lance Taylor <iant@google.com>
To: Anthony Green <green@moxielogic.com>
Cc: Uros Bizjak <ubizjak@gmail.com>,
"libffi-discuss@sourceware.org" <libffi-discuss@sourceware.org>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
Richard Henderson <rth@redhat.com>
Subject: Re: [PATCH, libffi, alpha]: Use FFI_ASSERT in ffi_closure_osf_inner
Date: Sat, 20 Sep 2014 22:04:00 -0000 [thread overview]
Message-ID: <CAKOQZ8y3gcp9QWoqsQ7Mbw5xxBvzntqm_RoOMn7Ji-zi7Yj56w@mail.gmail.com> (raw)
In-Reply-To: <8738bmip4u.fsf@moxielogic.com>
On Sat, Sep 20, 2014 at 3:04 AM, Anthony Green <green@moxielogic.com> wrote:
>
>> Attached patch fixes libgo reflect test failure with libffi closures.
>> The gccgo compiler started to use FFI closures recently; the compiler
>> passes ffi_type_void for structures with zero members.
>
> Why not just pass an FFI_TYPE_STRUCT with zero members?
Because when an empty struct is used as a return type libffi returns
a failure from ffi_prep_cif_core:
/* Initialize the return type if necessary */
if ((cif->rtype->size == 0) && (initialize_aggregate(cif->rtype) != FFI_OK))
return FFI_BAD_TYPEDEF;
This is because initialize_aggregate fails:
if (UNLIKELY(arg == NULL || arg->elements == NULL))
return FFI_BAD_TYPEDEF;
I haven't looked farther.
Ian
next prev parent reply other threads:[~2014-09-20 22:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-21 18:21 Uros Bizjak
2014-07-25 9:03 ` Uros Bizjak
2014-09-20 10:04 ` Anthony Green
2014-09-20 18:28 ` Jay
2014-09-20 22:04 ` Ian Lance Taylor [this message]
2014-09-21 9:17 ` Uros Bizjak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKOQZ8y3gcp9QWoqsQ7Mbw5xxBvzntqm_RoOMn7Ji-zi7Yj56w@mail.gmail.com \
--to=iant@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=green@moxielogic.com \
--cc=libffi-discuss@sourceware.org \
--cc=rth@redhat.com \
--cc=ubizjak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).