public inbox for libstdc++-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc/devel/c++-modules] libstdc++: Improve tests for std::atomic_flag
@ 2020-06-25 14:39 Nathan Sidwell
0 siblings, 0 replies; only message in thread
From: Nathan Sidwell @ 2020-06-25 14:39 UTC (permalink / raw)
To: gcc-cvs, libstdc++-cvs
https://gcc.gnu.org/g:e784f98027dbd5cdc46712751dcfba8278eb7fa9
commit e784f98027dbd5cdc46712751dcfba8278eb7fa9
Author: Jonathan Wakely <jwakely@redhat.com>
Date: Fri Jun 12 10:33:37 2020 +0100
libstdc++: Improve tests for std::atomic_flag
The tests for clear() and test_and_set() didn't cover all cases.
* testsuite/29_atomics/atomic_flag/clear/1.cc: Also test clear()
when the value is currently set.
* testsuite/29_atomics/atomic_flag/test_and_set/explicit.cc:
Actually check the return value.
* testsuite/29_atomics/atomic_flag/test_and_set/implicit.cc:
Likewise.
Diff:
---
libstdc++-v3/testsuite/29_atomics/atomic_flag/clear/1.cc | 8 ++++----
.../testsuite/29_atomics/atomic_flag/test_and_set/explicit.cc | 7 +++----
.../testsuite/29_atomics/atomic_flag/test_and_set/implicit.cc | 7 +++----
3 files changed, 10 insertions(+), 12 deletions(-)
diff --git a/libstdc++-v3/testsuite/29_atomics/atomic_flag/clear/1.cc b/libstdc++-v3/testsuite/29_atomics/atomic_flag/clear/1.cc
index 30d9075e372..ed5d11a5292 100644
--- a/libstdc++-v3/testsuite/29_atomics/atomic_flag/clear/1.cc
+++ b/libstdc++-v3/testsuite/29_atomics/atomic_flag/clear/1.cc
@@ -25,9 +25,9 @@ int main()
{
std::atomic_flag f = ATOMIC_FLAG_INIT;
- f.clear(); // set to false
+ f.clear(); // set to false
+ VERIFY( false == f.test_and_set() ); // return true
+ VERIFY( true == f.test_and_set() ); // return true
+ f.clear(); // set to false
VERIFY( false == f.test_and_set() ); // return previous false, set to true
- VERIFY( true == f.test_and_set() ); // return true
-
- return 0;
}
diff --git a/libstdc++-v3/testsuite/29_atomics/atomic_flag/test_and_set/explicit.cc b/libstdc++-v3/testsuite/29_atomics/atomic_flag/test_and_set/explicit.cc
index 5d6dbcc98a2..1934854d7f7 100644
--- a/libstdc++-v3/testsuite/29_atomics/atomic_flag/test_and_set/explicit.cc
+++ b/libstdc++-v3/testsuite/29_atomics/atomic_flag/test_and_set/explicit.cc
@@ -19,14 +19,13 @@
// <http://www.gnu.org/licenses/>.
#include <atomic>
+#include <testsuite_hooks.h>
int main()
{
using namespace std;
atomic_flag af = ATOMIC_FLAG_INIT;
- if (!af.test_and_set(memory_order_acquire))
- af.clear(memory_order_release);
-
- return 0;
+ VERIFY( ! af.test_and_set(memory_order_acquire) );
+ VERIFY( af.test_and_set(memory_order_acquire) );
}
diff --git a/libstdc++-v3/testsuite/29_atomics/atomic_flag/test_and_set/implicit.cc b/libstdc++-v3/testsuite/29_atomics/atomic_flag/test_and_set/implicit.cc
index 8e1284cd299..1934854d7f7 100644
--- a/libstdc++-v3/testsuite/29_atomics/atomic_flag/test_and_set/implicit.cc
+++ b/libstdc++-v3/testsuite/29_atomics/atomic_flag/test_and_set/implicit.cc
@@ -19,14 +19,13 @@
// <http://www.gnu.org/licenses/>.
#include <atomic>
+#include <testsuite_hooks.h>
int main()
{
using namespace std;
atomic_flag af = ATOMIC_FLAG_INIT;
- if (!af.test_and_set())
- af.clear();
-
- return 0;
+ VERIFY( ! af.test_and_set(memory_order_acquire) );
+ VERIFY( af.test_and_set(memory_order_acquire) );
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-06-25 14:39 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-25 14:39 [gcc/devel/c++-modules] libstdc++: Improve tests for std::atomic_flag Nathan Sidwell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).