public inbox for libstdc++-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc(refs/users/giulianob/heads/autopar_rebase2)] libstdc++: Add new testcase for comparison category types
@ 2020-08-17 22:47 Giuliano Belinassi
  0 siblings, 0 replies; only message in thread
From: Giuliano Belinassi @ 2020-08-17 22:47 UTC (permalink / raw)
  To: gcc-cvs, libstdc++-cvs

https://gcc.gnu.org/g:9196de6c3b5b6392340cccb42f28e27eb1ec5942

commit 9196de6c3b5b6392340cccb42f28e27eb1ec5942
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Wed May 27 13:13:19 2020 +0100

    libstdc++: Add new testcase for comparison category types
    
    Comparing a comparison category type to anything except a literal 0 is
    undefined. This verifies that at least some misuses are diagnosed at
    compile time.
    
            * testsuite/18_support/comparisons/categories/zero_neg.cc: New test.

Diff:
---
 .../18_support/comparisons/categories/zero_neg.cc  | 46 ++++++++++++++++++++++
 1 file changed, 46 insertions(+)

diff --git a/libstdc++-v3/testsuite/18_support/comparisons/categories/zero_neg.cc b/libstdc++-v3/testsuite/18_support/comparisons/categories/zero_neg.cc
new file mode 100644
index 00000000000..0a8af41acb9
--- /dev/null
+++ b/libstdc++-v3/testsuite/18_support/comparisons/categories/zero_neg.cc
@@ -0,0 +1,46 @@
+// Copyright (C) 2020 Free Software Foundation, Inc.
+//
+// This file is part of the GNU ISO C++ Library.  This library is free
+// software; you can redistribute it and/or modify it under the
+// terms of the GNU General Public License as published by the
+// Free Software Foundation; either version 3, or (at your option)
+// any later version.
+
+// This library is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+
+// You should have received a copy of the GNU General Public License along
+// with this library; see the file COPYING3.  If not see
+// <http://www.gnu.org/licenses/>.
+
+// { dg-options "-std=gnu++2a" }
+// { dg-do compile { target c++2a } }
+
+#include <compare>
+
+// C++20 [cmp.categories.pre]
+// "an argument other than a literal 0 is undefined"
+
+void
+test01()
+{
+  std::partial_ordering::equivalent == 0; // OK
+  std::weak_ordering::equivalent == 0;    // OK
+  std::strong_ordering::equivalent == 0;  // OK
+
+  std::partial_ordering::equivalent == 1; // { dg-error "invalid conversion" }
+  std::weak_ordering::equivalent == 1;    // { dg-error "invalid conversion" }
+  std::strong_ordering::equivalent == 1;  // { dg-error "invalid conversion" }
+
+  constexpr void* p = nullptr;
+  std::partial_ordering::equivalent == p; // { dg-error "invalid conversion" }
+  std::weak_ordering::equivalent == p;    // { dg-error "invalid conversion" }
+  std::strong_ordering::equivalent == p;  // { dg-error "invalid conversion" }
+
+  // Ideally these would be ill-formed, but the current code accepts it.
+  std::partial_ordering::equivalent == nullptr;
+  std::weak_ordering::equivalent == nullptr;
+  std::strong_ordering::equivalent == nullptr;
+}


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-08-17 22:47 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-17 22:47 [gcc(refs/users/giulianob/heads/autopar_rebase2)] libstdc++: Add new testcase for comparison category types Giuliano Belinassi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).