public inbox for libstdc++-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc(refs/users/giulianob/heads/autopar_rebase2)] libstdc++: Fix atomic<FP>::load (PR 95282)
@ 2020-08-17 22:48 Giuliano Belinassi
  0 siblings, 0 replies; only message in thread
From: Giuliano Belinassi @ 2020-08-17 22:48 UTC (permalink / raw)
  To: gcc-cvs, libstdc++-cvs

https://gcc.gnu.org/g:b9a260e8e95b2fbba128bd7b2e2c25563fb7f6ff

commit b9a260e8e95b2fbba128bd7b2e2c25563fb7f6ff
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Wed May 27 22:55:21 2020 +0100

    libstdc++: Fix atomic<FP>::load (PR 95282)
    
            PR libstdc++/95282
            * include/bits/atomic_base.h (__atomic_impl::load): Add
            cv-qualifiers to parameter so that _Tp is deduced as the
            unqualified type.
            * testsuite/29_atomics/atomic_float/95282.cc: New test.

Diff:
---
 libstdc++-v3/include/bits/atomic_base.h            |  2 +-
 .../testsuite/29_atomics/atomic_float/95282.cc     | 35 ++++++++++++++++++++++
 2 files changed, 36 insertions(+), 1 deletion(-)

diff --git a/libstdc++-v3/include/bits/atomic_base.h b/libstdc++-v3/include/bits/atomic_base.h
index 3b66b040976..01f77a0f372 100644
--- a/libstdc++-v3/include/bits/atomic_base.h
+++ b/libstdc++-v3/include/bits/atomic_base.h
@@ -871,7 +871,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
 
     template<typename _Tp>
       _GLIBCXX_ALWAYS_INLINE _Tp
-      load(_Tp* __ptr, memory_order __m) noexcept
+      load(const volatile _Tp* __ptr, memory_order __m) noexcept
       {
 	alignas(_Tp) unsigned char __buf[sizeof(_Tp)];
 	_Tp* __dest = reinterpret_cast<_Tp*>(__buf);
diff --git a/libstdc++-v3/testsuite/29_atomics/atomic_float/95282.cc b/libstdc++-v3/testsuite/29_atomics/atomic_float/95282.cc
new file mode 100644
index 00000000000..2de751c6ad4
--- /dev/null
+++ b/libstdc++-v3/testsuite/29_atomics/atomic_float/95282.cc
@@ -0,0 +1,35 @@
+// Copyright (C) 2020 Free Software Foundation, Inc.
+//
+// This file is part of the GNU ISO C++ Library.  This library is free
+// software; you can redistribute it and/or modify it under the
+// terms of the GNU General Public License as published by the
+// Free Software Foundation; either version 3, or (at your option)
+// any later version.
+
+// This library is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+
+// You should have received a copy of the GNU General Public License along
+// with this library; see the file COPYING3.  If not see
+// <http://www.gnu.org/licenses/>.
+
+// { dg-options "-std=gnu++2a" }
+// { dg-do compile { target c++2a } }
+
+#include <atomic>
+
+float
+test01()
+{
+  std::atomic<float> a;
+  return a.load();
+}
+
+float
+test02()
+{
+  volatile std::atomic<float> a;
+  return a.load();
+}


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-08-17 22:48 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-17 22:48 [gcc(refs/users/giulianob/heads/autopar_rebase2)] libstdc++: Fix atomic<FP>::load (PR 95282) Giuliano Belinassi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).