public inbox for libstdc++-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc(refs/users/giulianob/heads/autopar_rebase2)] libstdc++: Fix compatibility support in unique_ptr pretty printer
@ 2020-08-18 1:35 Giuliano Belinassi
0 siblings, 0 replies; only message in thread
From: Giuliano Belinassi @ 2020-08-18 1:35 UTC (permalink / raw)
To: gcc-cvs, libstdc++-cvs
https://gcc.gnu.org/g:cd92527c2e7cdf7594d6b3b48dd77017888b04f0
commit cd92527c2e7cdf7594d6b3b48dd77017888b04f0
Author: Jonathan Wakely <jwakely@redhat.com>
Date: Mon Aug 10 18:44:06 2020 +0100
libstdc++: Fix compatibility support in unique_ptr pretty printer
The support for the old std::unique_ptr implementation was failing,
because it tried to work on a typedef instead of the underlying type.
The test supposed to verify the support worked wasn't using a typedef,
so didn't notice the problem.
libstdc++-v3/ChangeLog:
* python/libstdcxx/v6/printers.py (UniquePointerPrinter.__init__):
Use gdb.Type.strip_typedefs().
* testsuite/libstdc++-prettyprinters/compat.cc: Use a typedef in
the emulated old type.
Diff:
---
libstdc++-v3/python/libstdcxx/v6/printers.py | 6 +++---
libstdc++-v3/testsuite/libstdc++-prettyprinters/compat.cc | 4 +++-
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/libstdc++-v3/python/libstdcxx/v6/printers.py b/libstdc++-v3/python/libstdcxx/v6/printers.py
index 0bf307b8e5f..c0f061f79c1 100644
--- a/libstdc++-v3/python/libstdcxx/v6/printers.py
+++ b/libstdc++-v3/python/libstdcxx/v6/printers.py
@@ -245,7 +245,7 @@ class UniquePointerPrinter:
def __init__ (self, typename, val):
self.val = val
- impl_type = val.type.fields()[0].type.tag
+ impl_type = val.type.fields()[0].type.strip_typedefs()
# Check for new implementations first:
if is_specialization_of(impl_type, '__uniq_ptr_data') \
or is_specialization_of(impl_type, '__uniq_ptr_impl'):
@@ -253,7 +253,7 @@ class UniquePointerPrinter:
elif is_specialization_of(impl_type, 'tuple'):
tuple_member = val['_M_t']
else:
- raise ValueError("Unsupported implementation for unique_ptr: %s" % impl_type)
+ raise ValueError("Unsupported implementation for unique_ptr: %s" % str(impl_type))
tuple_impl_type = tuple_member.type.fields()[0].type # _Tuple_impl
tuple_head_type = tuple_impl_type.fields()[1].type # _Head_base
head_field = tuple_head_type.fields()[0]
@@ -262,7 +262,7 @@ class UniquePointerPrinter:
elif head_field.is_base_class:
self.pointer = tuple_member.cast(head_field.type)
else:
- raise ValueError("Unsupported implementation for tuple in unique_ptr: %s" % impl_type)
+ raise ValueError("Unsupported implementation for tuple in unique_ptr: %s" % str(impl_type))
def children (self):
return SmartPtrIterator(self.pointer)
diff --git a/libstdc++-v3/testsuite/libstdc++-prettyprinters/compat.cc b/libstdc++-v3/testsuite/libstdc++-prettyprinters/compat.cc
index f1c3b599634..c681becf8b9 100644
--- a/libstdc++-v3/testsuite/libstdc++-prettyprinters/compat.cc
+++ b/libstdc++-v3/testsuite/libstdc++-prettyprinters/compat.cc
@@ -53,7 +53,9 @@ namespace std
{
unique_ptr(T* p) { _M_t._M_head_impl = p; }
- tuple<T*, D> _M_t;
+ using __tuple_type = tuple<T*, D>;
+
+ __tuple_type _M_t;
};
// Old representation of std::optional, before GCC 9
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-08-18 1:35 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-18 1:35 [gcc(refs/users/giulianob/heads/autopar_rebase2)] libstdc++: Fix compatibility support in unique_ptr pretty printer Giuliano Belinassi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).