public inbox for libstdc++-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc(refs/users/wschmidt/heads/builtins3)] libstdc++: Fix failing tests for AIX
@ 2020-08-18 18:35 William Schmidt
  0 siblings, 0 replies; only message in thread
From: William Schmidt @ 2020-08-18 18:35 UTC (permalink / raw)
  To: gcc-cvs, libstdc++-cvs

https://gcc.gnu.org/g:fe8d7fec4db838cae536eeef1965db83959cf6ee

commit fe8d7fec4db838cae536eeef1965db83959cf6ee
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Tue Aug 11 16:16:22 2020 +0100

    libstdc++: Fix failing tests for AIX
    
    These two tests fail on AIX because <sys/thread.h> defines struct thread
    in the global namespace (despite it not being a reserved name). That
    means the using-declaration that adds it to the global namespace causes
    a redeclaration error.
    
    libstdc++-v3/ChangeLog:
    
            * testsuite/30_threads/thread/cons/84535.cc: Use a custom
            namespace.
            * testsuite/30_threads/thread/cons/lwg2097.cc: Likewise.

Diff:
---
 libstdc++-v3/testsuite/30_threads/thread/cons/84535.cc   | 3 +++
 libstdc++-v3/testsuite/30_threads/thread/cons/lwg2097.cc | 3 +++
 2 files changed, 6 insertions(+)

diff --git a/libstdc++-v3/testsuite/30_threads/thread/cons/84535.cc b/libstdc++-v3/testsuite/30_threads/thread/cons/84535.cc
index 7846d3f7b68..711687b4f5c 100644
--- a/libstdc++-v3/testsuite/30_threads/thread/cons/84535.cc
+++ b/libstdc++-v3/testsuite/30_threads/thread/cons/84535.cc
@@ -20,6 +20,8 @@
 
 #include <thread>
 
+namespace __gnu_test
+{
 using std::is_constructible;
 using std::thread;
 
@@ -28,3 +30,4 @@ static_assert(!is_constructible<thread, thread, int>::value, "");
 static_assert(!is_constructible<thread, thread&, int>::value, "");
 static_assert(!is_constructible<thread, const thread&, int>::value, "");
 static_assert(!is_constructible<thread, const thread&&, int>::value, "");
+}
diff --git a/libstdc++-v3/testsuite/30_threads/thread/cons/lwg2097.cc b/libstdc++-v3/testsuite/30_threads/thread/cons/lwg2097.cc
index e0d588e51f9..1ad2a76cb58 100644
--- a/libstdc++-v3/testsuite/30_threads/thread/cons/lwg2097.cc
+++ b/libstdc++-v3/testsuite/30_threads/thread/cons/lwg2097.cc
@@ -20,9 +20,12 @@
 
 #include <thread>
 
+namespace __gnu_test
+{
 using std::thread;
 using std::is_constructible;
 
 static_assert( !is_constructible<thread, thread&>::value, "" );
 static_assert( !is_constructible<thread, const thread&>::value, "" );
 static_assert( !is_constructible<thread, const thread>::value, "" );
+}


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-08-18 18:35 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-18 18:35 [gcc(refs/users/wschmidt/heads/builtins3)] libstdc++: Fix failing tests for AIX William Schmidt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).