public inbox for libstdc++-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r12-3589] libstdc++: Add noexcept to std::to_string overloads that don't allocate
@ 2021-09-16 22:05 Jonathan Wakely
  0 siblings, 0 replies; only message in thread
From: Jonathan Wakely @ 2021-09-16 22:05 UTC (permalink / raw)
  To: gcc-cvs, libstdc++-cvs

https://gcc.gnu.org/g:9d813ddd978aff75001d53fe55ff15e9167bb4d0

commit r12-3589-g9d813ddd978aff75001d53fe55ff15e9167bb4d0
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Wed Sep 15 21:40:20 2021 +0100

    libstdc++: Add noexcept to std::to_string overloads that don't allocate
    
    When the values is guaranteed to fit in the SSO buffer we know the
    string won't allocate, so the function can be noexcept. For 32-bit
    integers, we know they need no more than 9 bytes (or 10 with a minus
    sign) and the SSO buffer is 15 bytes.
    
    Signed-off-by: Jonathan Wakely <jwakely@redhat.com>
    
    libstdc++-v3/ChangeLog:
    
            * include/bits/basic_string.h [_GLIBCXX_USE_CXX11_ABI]
            (to_string): Add noexcept if the type width is 32 bits or less.

Diff:
---
 libstdc++-v3/include/bits/basic_string.h | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/libstdc++-v3/include/bits/basic_string.h b/libstdc++-v3/include/bits/basic_string.h
index b61fe05efcf..24c454d863a 100644
--- a/libstdc++-v3/include/bits/basic_string.h
+++ b/libstdc++-v3/include/bits/basic_string.h
@@ -3718,6 +3718,9 @@ _GLIBCXX_BEGIN_NAMESPACE_CXX11
 
   inline string
   to_string(int __val)
+#if _GLIBCXX_USE_CXX11_ABI && (__CHAR_BIT__ * __SIZEOF_INT__) <= 32
+  noexcept // any 32-bit value fits in the SSO buffer
+#endif
   {
     const bool __neg = __val < 0;
     const unsigned __uval = __neg ? (unsigned)~__val + 1u : __val;
@@ -3729,6 +3732,9 @@ _GLIBCXX_BEGIN_NAMESPACE_CXX11
 
   inline string
   to_string(unsigned __val)
+#if _GLIBCXX_USE_CXX11_ABI && (__CHAR_BIT__ * __SIZEOF_INT__) <= 32
+  noexcept // any 32-bit value fits in the SSO buffer
+#endif
   {
     string __str(__detail::__to_chars_len(__val), '\0');
     __detail::__to_chars_10_impl(&__str[0], __str.size(), __val);
@@ -3737,6 +3743,9 @@ _GLIBCXX_BEGIN_NAMESPACE_CXX11
 
   inline string
   to_string(long __val)
+#if _GLIBCXX_USE_CXX11_ABI && (__CHAR_BIT__ * __SIZEOF_LONG__) <= 32
+  noexcept // any 32-bit value fits in the SSO buffer
+#endif
   {
     const bool __neg = __val < 0;
     const unsigned long __uval = __neg ? (unsigned long)~__val + 1ul : __val;
@@ -3748,6 +3757,9 @@ _GLIBCXX_BEGIN_NAMESPACE_CXX11
 
   inline string
   to_string(unsigned long __val)
+#if _GLIBCXX_USE_CXX11_ABI && (__CHAR_BIT__ * __SIZEOF_LONG__) <= 32
+  noexcept // any 32-bit value fits in the SSO buffer
+#endif
   {
     string __str(__detail::__to_chars_len(__val), '\0');
     __detail::__to_chars_10_impl(&__str[0], __str.size(), __val);


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-09-16 22:05 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-16 22:05 [gcc r12-3589] libstdc++: Add noexcept to std::to_string overloads that don't allocate Jonathan Wakely

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).