public inbox for libstdc++-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r12-7522] libstdc++: Use visibility pragmas instead of attributes [PR104807]
@ 2022-03-07 15:11 Jonathan Wakely
  0 siblings, 0 replies; only message in thread
From: Jonathan Wakely @ 2022-03-07 15:11 UTC (permalink / raw)
  To: gcc-cvs, libstdc++-cvs

https://gcc.gnu.org/g:4cb935cb69f12088975fa7f6907c6ace0580e2dd

commit r12-7522-g4cb935cb69f12088975fa7f6907c6ace0580e2dd
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Mon Mar 7 15:07:05 2022 +0000

    libstdc++: Use visibility pragmas instead of attributes [PR104807]
    
    The _GLIBCXX_PSEUDO_VISIBILITY macro isn't defined until after including
    os_defines.h, so we can't use _GLIBCXX_VISIBILITY early in c++config.
    Replace the uses of that macro with #pragma visibility push(default)
    instead.
    
    libstdc++-v3/ChangeLog:
    
            PR libstdc++/104807
            * include/bits/c++config (__terminate, __glibcxx_assert_fail):
            Replace _GLIBCXX_VISIBILITY on function with visibility pragma.
            (__is_constant_evaluated): Add visibility pragma.

Diff:
---
 libstdc++-v3/include/bits/c++config | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/libstdc++-v3/include/bits/c++config b/libstdc++-v3/include/bits/c++config
index 6c134f13509..2798b9786dc 100644
--- a/libstdc++-v3/include/bits/c++config
+++ b/libstdc++-v3/include/bits/c++config
@@ -302,15 +302,16 @@ namespace std
   typedef decltype(nullptr)	nullptr_t;
 #endif
 
+#pragma GCC visibility push(default)
   // This allows the library to terminate without including all of <exception>
   // and without making the declaration of std::terminate visible to users.
   extern "C++" __attribute__ ((__noreturn__, __always_inline__))
-  _GLIBCXX_VISIBILITY(default)
   inline void __terminate() _GLIBCXX_USE_NOEXCEPT
   {
     void terminate() _GLIBCXX_USE_NOEXCEPT __attribute__ ((__noreturn__));
     terminate();
   }
+#pragma GCC visibility pop
 }
 
 #define _GLIBCXX_USE_DUAL_ABI
@@ -506,6 +507,7 @@ namespace std
 
 namespace std
 {
+#pragma GCC visibility push(default)
   // Internal version of std::is_constant_evaluated().
   // This can be used without checking if the compiler supports the feature.
   // The macro _GLIBCXX_HAVE_IS_CONSTANT_EVALUATED can be used to check if
@@ -523,6 +525,7 @@ namespace std
     return false;
 #endif
   }
+#pragma GCC visibility pop
 }
 
 // Debug Mode implies checking assertions.
@@ -553,13 +556,15 @@ namespace std
 # ifdef _GLIBCXX_VERBOSE_ASSERT
 namespace std
 {
+#pragma GCC visibility push(default)
   // Avoid the use of assert, because we're trying to keep the <cassert>
   // include out of the mix.
-  extern "C++" _GLIBCXX_NORETURN _GLIBCXX_VISIBILITY(default)
+  extern "C++" _GLIBCXX_NORETURN
   void
   __glibcxx_assert_fail(const char* __file, int __line,
 			const char* __function, const char* __condition)
   _GLIBCXX_NOEXCEPT;
+#pragma GCC visibility pop
 }
 #define __glibcxx_assert_impl(_Condition)				\
   if (__builtin_expect(!bool(_Condition), false))			\


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-03-07 15:11 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-07 15:11 [gcc r12-7522] libstdc++: Use visibility pragmas instead of attributes [PR104807] Jonathan Wakely

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).