public inbox for libstdc++-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r12-8061] libstdc++: Fix std::bad_expected_access constructor [PR105146]
@ 2022-04-08 17:30 Jonathan Wakely
  0 siblings, 0 replies; only message in thread
From: Jonathan Wakely @ 2022-04-08 17:30 UTC (permalink / raw)
  To: gcc-cvs, libstdc++-cvs

https://gcc.gnu.org/g:29e355d0d671c7474935220e8bef784f05143820

commit r12-8061-g29e355d0d671c7474935220e8bef784f05143820
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Fri Apr 8 18:04:04 2022 +0100

    libstdc++: Fix std::bad_expected_access constructor [PR105146]
    
    libstdc++-v3/ChangeLog:
    
            PR libstdc++/105146
            * include/std/expected (bad_expected_access): Move constructor
            parameter.
            * testsuite/20_util/expected/bad.cc: New test.

Diff:
---
 libstdc++-v3/include/std/expected              |  2 +-
 libstdc++-v3/testsuite/20_util/expected/bad.cc | 15 +++++++++++++++
 2 files changed, 16 insertions(+), 1 deletion(-)

diff --git a/libstdc++-v3/include/std/expected b/libstdc++-v3/include/std/expected
index 39d07cda4a9..7b01a17fb57 100644
--- a/libstdc++-v3/include/std/expected
+++ b/libstdc++-v3/include/std/expected
@@ -95,7 +95,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
     class bad_expected_access : public bad_expected_access<void> {
     public:
       explicit
-      bad_expected_access(_Er __e) : _M_val(__e) { }
+      bad_expected_access(_Er __e) : _M_val(std::move(__e)) { }
 
       // XXX const char* what() const noexcept override;
 
diff --git a/libstdc++-v3/testsuite/20_util/expected/bad.cc b/libstdc++-v3/testsuite/20_util/expected/bad.cc
new file mode 100644
index 00000000000..17bc6d69e88
--- /dev/null
+++ b/libstdc++-v3/testsuite/20_util/expected/bad.cc
@@ -0,0 +1,15 @@
+// { dg-options "-std=gnu++23" }
+// { dg-do compile }
+
+#include <expected>
+
+struct E {
+  E() = default;
+  E(E&&) = default;
+};
+
+void
+test_pr105146()
+{
+  std::bad_expected_access(E{});
+}


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-04-08 17:30 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-08 17:30 [gcc r12-8061] libstdc++: Fix std::bad_expected_access constructor [PR105146] Jonathan Wakely

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).