public inbox for libstdc++-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r12-8124] libstdc++: shrink-to-fit in std::basic_stacktrace::current(skip, max)
@ 2022-04-12 21:39 Jonathan Wakely
  0 siblings, 0 replies; only message in thread
From: Jonathan Wakely @ 2022-04-12 21:39 UTC (permalink / raw)
  To: gcc-cvs, libstdc++-cvs

https://gcc.gnu.org/g:b2c007b87dcd5db5d59447de2081777aea66f35f

commit r12-8124-gb2c007b87dcd5db5d59447de2081777aea66f35f
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Tue Apr 12 17:17:20 2022 +0100

    libstdc++: shrink-to-fit in std::basic_stacktrace::current(skip, max)
    
    If a large stacktrace is reduced to a max depth that is less than half
    the capacity it will now be reallocated to remove the unused capacity.
    
    libstdc++-v3/ChangeLog:
    
            * include/std/stacktrace (basic_stacktrace::current): Reallocate
            a smaller container if the unused capacity is larger than the
            used size.

Diff:
---
 libstdc++-v3/include/std/stacktrace | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)

diff --git a/libstdc++-v3/include/std/stacktrace b/libstdc++-v3/include/std/stacktrace
index 382d900a822..98ce9231150 100644
--- a/libstdc++-v3/include/std/stacktrace
+++ b/libstdc++-v3/include/std/stacktrace
@@ -289,7 +289,20 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
 	    if (__err < 0)
 	      __ret._M_clear();
 	    else if (__ret.size() > __max_depth)
-	      __ret._M_impl._M_resize(__max_depth, __ret._M_alloc);
+	      {
+		__ret._M_impl._M_resize(__max_depth, __ret._M_alloc);
+
+		if (__ret._M_impl._M_capacity / 2 >= __max_depth)
+		  {
+		    // shrink to fit
+		    _Impl __tmp = __ret._M_impl._M_clone(__ret._M_alloc);
+		    if (__tmp._M_capacity)
+		      {
+			__ret._M_clear();
+			__ret._M_impl = __tmp;
+		      }
+		  }
+	      }
 	  }
 	return __ret;
       }


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-04-12 21:39 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-12 21:39 [gcc r12-8124] libstdc++: shrink-to-fit in std::basic_stacktrace::current(skip, max) Jonathan Wakely

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).