public inbox for libstdc++-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc(refs/users/pheeck/heads/sccp)] libstdc++: Workaround buggy printf on Solaris in to_chars/float128_c++23.cc test [PR107815]
@ 2023-02-15 10:23 Filip Kastl
0 siblings, 0 replies; only message in thread
From: Filip Kastl @ 2023-02-15 10:23 UTC (permalink / raw)
To: gcc-cvs, libstdc++-cvs
https://gcc.gnu.org/g:5e60b9e3dc5745385e3a565a0d4586a421f88ca7
commit 5e60b9e3dc5745385e3a565a0d4586a421f88ca7
Author: Jakub Jelinek <jakub@redhat.com>
Date: Thu Nov 24 10:37:50 2022 +0100
libstdc++: Workaround buggy printf on Solaris in to_chars/float128_c++23.cc test [PR107815]
As mentioned in the PR, Solaris apparently can handle right
printf ("%.0Lf\n", 1e+202L * __DBL_MAX__);
which prints 511 chars long number, but can't handle
printf ("%.0Lf\n", 1e+203L * __DBL_MAX__);
nor
printf ("%.0Lf\n", __LDBL_MAX__);
properly, instead of printing 512 chars long number for the former and
4933 chars long number for the second, it handles them as
if user asked for "%.0Le\n" in those cases.
The following patch disables the single problematic value that fails
in the test, and also fixes commented out debugging printouts.
2022-11-24 Jakub Jelinek <jakub@redhat.com>
PR libstdc++/107815
* testsuite/20_util/to_chars/float128_c++23.cc (test): Disable
__FLT128_MAX__ test on Solaris. Fix up commented out debugging
printouts.
Diff:
---
libstdc++-v3/testsuite/20_util/to_chars/float128_c++23.cc | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/libstdc++-v3/testsuite/20_util/to_chars/float128_c++23.cc b/libstdc++-v3/testsuite/20_util/to_chars/float128_c++23.cc
index 28824c9c6ff..735a507827a 100644
--- a/libstdc++-v3/testsuite/20_util/to_chars/float128_c++23.cc
+++ b/libstdc++-v3/testsuite/20_util/to_chars/float128_c++23.cc
@@ -52,14 +52,17 @@ test(std::chars_format fmt = std::chars_format{})
std::numbers::inv_sqrt3_v<std::float128_t>,
std::numbers::egamma_v<std::float128_t>,
std::numbers::phi_v<std::float128_t>,
+// Solaris has non-conforming printf, see PR98384 and PR107815.
+#if !(defined(__sun__) && defined(__svr4__))
std::numeric_limits<std::float128_t>::max()
+#endif
};
char str1[10000], str2[10000];
for (auto u : tests)
{
auto [ptr1, ec1] = std::to_chars(str1, str1 + sizeof(str1), u, fmt);
VERIFY( ec1 == std::errc() );
-// std::cout << i << ' ' << std::string_view (str1, ptr1) << '\n';
+// std::cout << u << ' ' << std::string_view (str1, ptr1) << '\n';
if (fmt == std::chars_format::fixed)
{
auto [ptr2, ec2] = std::to_chars(str2, str2 + (ptr1 - str1), u, fmt);
@@ -76,7 +79,7 @@ test(std::chars_format fmt = std::chars_format{})
auto [ptr5, ec5] = std::to_chars(str1, str1 + sizeof(str1), u, fmt, 90);
VERIFY( ec5 == std::errc() );
-// std::cout << i << ' ' << std::string_view (str1, ptr5) << '\n';
+// std::cout << u << ' ' << std::string_view (str1, ptr5) << '\n';
v = 4.0f128;
auto [ptr6, ec6] = std::from_chars(str1, ptr5, v,
fmt == std::chars_format{}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-02-15 10:23 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-15 10:23 [gcc(refs/users/pheeck/heads/sccp)] libstdc++: Workaround buggy printf on Solaris in to_chars/float128_c++23.cc test [PR107815] Filip Kastl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).