public inbox for libstdc++-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r11-10590] libstdc++: Skip integer division optimization for Clang
@ 2023-03-21 19:38 Matthias Kretz
  0 siblings, 0 replies; only message in thread
From: Matthias Kretz @ 2023-03-21 19:38 UTC (permalink / raw)
  To: gcc-cvs, libstdc++-cvs

https://gcc.gnu.org/g:2f94d8c7a5370f4474b1ece17ec9aa46c48d0e8d

commit r11-10590-g2f94d8c7a5370f4474b1ece17ec9aa46c48d0e8d
Author: Matthias Kretz <m.kretz@gsi.de>
Date:   Tue Mar 21 14:20:52 2023 +0100

    libstdc++: Skip integer division optimization for Clang
    
    Clang ICEs on _SimdImplX86::_S_divides. The function is only working
    around a missed optimization and not necessary for correctness.
    Therefore, don't use it for Clang.
    
    Signed-off-by: Matthias Kretz <m.kretz@gsi.de>
    
    libstdc++-v3/ChangeLog:
    
            * include/experimental/bits/simd_detail.h: Don't define
            _GLIBCXX_SIMD_WORKAROUND_PR90993 for Clang.
            * include/experimental/bits/simd_x86.h (_S_divides): Remove
            check for __clang__.
    
    (cherry picked from commit 403e48ef441b0502af46ad3598f699f4a1611791)

Diff:
---
 libstdc++-v3/include/experimental/bits/simd_detail.h | 2 ++
 libstdc++-v3/include/experimental/bits/simd_x86.h    | 4 ++--
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/libstdc++-v3/include/experimental/bits/simd_detail.h b/libstdc++-v3/include/experimental/bits/simd_detail.h
index ecd059610cd..ca0bbdf8891 100644
--- a/libstdc++-v3/include/experimental/bits/simd_detail.h
+++ b/libstdc++-v3/include/experimental/bits/simd_detail.h
@@ -276,7 +276,9 @@
 #endif
 
 // integer division not optimized
+#ifndef __clang__
 #define _GLIBCXX_SIMD_WORKAROUND_PR90993 1
+#endif
 
 // very bad codegen for extraction and concatenation of 128/256 "subregisters"
 // with sizeof(element type) < 8: https://godbolt.org/g/mqUsgM
diff --git a/libstdc++-v3/include/experimental/bits/simd_x86.h b/libstdc++-v3/include/experimental/bits/simd_x86.h
index 8df230fb773..4fff8df5db0 100644
--- a/libstdc++-v3/include/experimental/bits/simd_x86.h
+++ b/libstdc++-v3/include/experimental/bits/simd_x86.h
@@ -1422,7 +1422,7 @@ template <typename _Abi>
 		},
 		[&__xf,
 		 &__yf](auto __i) -> _SimdWrapper<_Float, __n_intermediate> {
-#if !defined __clang__ && __GCC_IEC_559 == 0
+#if __GCC_IEC_559 == 0
 		  // If -freciprocal-math is active, using the `/` operator is
 		  // incorrect because it may be translated to an imprecise
 		  // multiplication with reciprocal. We need to use inline
@@ -1477,7 +1477,7 @@ template <typename _Abi>
 	  */
 	return _Base::_S_divides(__x, __y);
       }
-  #endif // _GLIBCXX_SIMD_WORKAROUND_PR90993
+#endif // _GLIBCXX_SIMD_WORKAROUND_PR90993
 
     // }}}
     // _S_modulus {{{

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-03-21 19:38 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-21 19:38 [gcc r11-10590] libstdc++: Skip integer division optimization for Clang Matthias Kretz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).