public inbox for libstdc++-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r10-11471] libstdc++: Fix std::numeric_limits::lowest() test for strict modes
@ 2023-06-23 16:13 Jonathan Wakely
  0 siblings, 0 replies; only message in thread
From: Jonathan Wakely @ 2023-06-23 16:13 UTC (permalink / raw)
  To: gcc-cvs, libstdc++-cvs

https://gcc.gnu.org/g:f11b715ba891ecc936888cc5d4d6a3fab192b5f6

commit r10-11471-gf11b715ba891ecc936888cc5d4d6a3fab192b5f6
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Mon Oct 11 13:28:32 2021 +0100

    libstdc++: Fix std::numeric_limits::lowest() test for strict modes
    
    This test uses std::is_integral to decide whether we are testing an
    integral or floating-point type. But that fails for __int128 because
    is_integral<__int128> is false in strict modes. By using
    numeric_limits::is_integer instead we get the right answer for all types
    that have a numeric_limits specialization.
    
    We can also simplify the test by removing the unnecessary tag
    dispatching.
    
    libstdc++-v3/ChangeLog:
    
            * testsuite/18_support/numeric_limits/lowest.cc: Use
            numeric_limits<T>::is_integer instead of is_integral<T>::value.
    
    (cherry picked from commit 45ba5426c129993704a73e6ace4016eaa950d7ee)

Diff:
---
 .../testsuite/18_support/numeric_limits/lowest.cc    | 20 +++++---------------
 1 file changed, 5 insertions(+), 15 deletions(-)

diff --git a/libstdc++-v3/testsuite/18_support/numeric_limits/lowest.cc b/libstdc++-v3/testsuite/18_support/numeric_limits/lowest.cc
index 918a4494d60..33015409365 100644
--- a/libstdc++-v3/testsuite/18_support/numeric_limits/lowest.cc
+++ b/libstdc++-v3/testsuite/18_support/numeric_limits/lowest.cc
@@ -23,30 +23,20 @@
 // 18.2.1.1 template class numeric_limits
 
 #include <limits>
-#include <type_traits>
 #include <testsuite_hooks.h>
 
 template<typename T>
   void
-  do_test(std::true_type)
+  do_test()
   {
     T limits_min = std::numeric_limits<T>::min();
-    VERIFY( std::numeric_limits<T>::lowest() == limits_min );
-  }
-
-template<typename T>
-  void
-  do_test(std::false_type)
-  {
     T limits_max = std::numeric_limits<T>::max();
-    VERIFY( std::numeric_limits<T>::lowest() == -limits_max );
+    if (std::numeric_limits<T>::is_integer)
+      VERIFY( std::numeric_limits<T>::lowest() == limits_min );
+    else
+      VERIFY( std::numeric_limits<T>::lowest() == -limits_max );
   }
 
-template<typename Tp>
-  void
-  do_test()
-  { do_test<Tp>(typename std::is_integral<Tp>::type()); }
-
 void test01()
 {
   do_test<char>();

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-06-23 16:13 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-23 16:13 [gcc r10-11471] libstdc++: Fix std::numeric_limits::lowest() test for strict modes Jonathan Wakely

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).