public inbox for libstdc++-cvs@sourceware.org
help / color / mirror / Atom feed
From: Jan Hubicka <hubicka@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org, libstdc++-cvs@gcc.gnu.org
Subject: [gcc r14-2157] Add cold attribute to throw wrappers and terminate
Date: Wed, 28 Jun 2023 09:47:27 +0000 (GMT)	[thread overview]
Message-ID: <20230628094727.D756F3858D35@sourceware.org> (raw)

https://gcc.gnu.org/g:45c53768b6fa3d737ae818e31d3c50da62e0ad2b

commit r14-2157-g45c53768b6fa3d737ae818e31d3c50da62e0ad2b
Author: Jan Hubicka <jh@suse.cz>
Date:   Wed Jun 28 11:45:15 2023 +0200

    Add cold attribute to throw wrappers and terminate
    
            PR middle-end/109849
            * include/bits/c++config (std::__terminate): Mark cold.
            * include/bits/functexcept.h: Mark everything as cold.
            * libsupc++/exception: Mark terminate and unexpected as cold.

Diff:
---
 libstdc++-v3/include/bits/c++config     |  2 +-
 libstdc++-v3/include/bits/functexcept.h | 34 ++++++++++++++++-----------------
 libstdc++-v3/libsupc++/exception        |  4 ++--
 3 files changed, 20 insertions(+), 20 deletions(-)

diff --git a/libstdc++-v3/include/bits/c++config b/libstdc++-v3/include/bits/c++config
index 009a017b048..dd47f274d5f 100644
--- a/libstdc++-v3/include/bits/c++config
+++ b/libstdc++-v3/include/bits/c++config
@@ -320,7 +320,7 @@ namespace std
   extern "C++" __attribute__ ((__noreturn__, __always_inline__))
   inline void __terminate() _GLIBCXX_USE_NOEXCEPT
   {
-    void terminate() _GLIBCXX_USE_NOEXCEPT __attribute__ ((__noreturn__));
+    void terminate() _GLIBCXX_USE_NOEXCEPT __attribute__ ((__noreturn__,__cold__));
     terminate();
   }
 #pragma GCC visibility pop
diff --git a/libstdc++-v3/include/bits/functexcept.h b/libstdc++-v3/include/bits/functexcept.h
index 89972baf2c9..c43ca82b953 100644
--- a/libstdc++-v3/include/bits/functexcept.h
+++ b/libstdc++-v3/include/bits/functexcept.h
@@ -57,61 +57,61 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
 
   // Helper for exception objects in <typeinfo>
   void
-  __throw_bad_cast(void) __attribute__((__noreturn__));
+  __throw_bad_cast(void) __attribute__((__noreturn__,__cold__));
 
   void
-  __throw_bad_typeid(void) __attribute__((__noreturn__));
+  __throw_bad_typeid(void) __attribute__((__noreturn__,__cold__));
 
   // Helpers for exception objects in <stdexcept>
   void
-  __throw_logic_error(const char*) __attribute__((__noreturn__));
+  __throw_logic_error(const char*) __attribute__((__noreturn__,__cold__));
 
   void
-  __throw_domain_error(const char*) __attribute__((__noreturn__));
+  __throw_domain_error(const char*) __attribute__((__noreturn__,__cold__));
 
   void
-  __throw_invalid_argument(const char*) __attribute__((__noreturn__));
+  __throw_invalid_argument(const char*) __attribute__((__noreturn__,__cold__));
 
   void
-  __throw_length_error(const char*) __attribute__((__noreturn__));
+  __throw_length_error(const char*) __attribute__((__noreturn__,__cold__));
 
   void
-  __throw_out_of_range(const char*) __attribute__((__noreturn__));
+  __throw_out_of_range(const char*) __attribute__((__noreturn__,__cold__));
 
   void
-  __throw_out_of_range_fmt(const char*, ...) __attribute__((__noreturn__))
+  __throw_out_of_range_fmt(const char*, ...) __attribute__((__noreturn__,__cold__))
     __attribute__((__format__(__gnu_printf__, 1, 2)));
 
   void
-  __throw_runtime_error(const char*) __attribute__((__noreturn__));
+  __throw_runtime_error(const char*) __attribute__((__noreturn__,__cold__));
 
   void
-  __throw_range_error(const char*) __attribute__((__noreturn__));
+  __throw_range_error(const char*) __attribute__((__noreturn__,__cold__));
 
   void
-  __throw_overflow_error(const char*) __attribute__((__noreturn__));
+  __throw_overflow_error(const char*) __attribute__((__noreturn__,__cold__));
 
   void
-  __throw_underflow_error(const char*) __attribute__((__noreturn__));
+  __throw_underflow_error(const char*) __attribute__((__noreturn__,__cold__));
 
   // Helpers for exception objects in <ios>
   void
-  __throw_ios_failure(const char*) __attribute__((__noreturn__));
+  __throw_ios_failure(const char*) __attribute__((__noreturn__,__cold__));
 
   void
-  __throw_ios_failure(const char*, int) __attribute__((__noreturn__));
+  __throw_ios_failure(const char*, int) __attribute__((__noreturn__,__cold__));
 
   // Helpers for exception objects in <system_error>
   void
-  __throw_system_error(int) __attribute__((__noreturn__));
+  __throw_system_error(int) __attribute__((__noreturn__,__cold__));
 
   // Helpers for exception objects in <future>
   void
-  __throw_future_error(int) __attribute__((__noreturn__));
+  __throw_future_error(int) __attribute__((__noreturn__,__cold__));
 
   // Helpers for exception objects in <functional>
   void
-  __throw_bad_function_call() __attribute__((__noreturn__));
+  __throw_bad_function_call() __attribute__((__noreturn__,__cold__));
 
 #else // ! HOSTED
 
diff --git a/libstdc++-v3/libsupc++/exception b/libstdc++-v3/libsupc++/exception
index a34386e6026..00a6347ebe5 100644
--- a/libstdc++-v3/libsupc++/exception
+++ b/libstdc++-v3/libsupc++/exception
@@ -75,7 +75,7 @@ namespace std _GLIBCXX_VISIBILITY(default)
 
   /** The runtime will call this function if %exception handling must be
    *  abandoned for any reason.  It can also be called by the user.  */
-  void terminate() _GLIBCXX_USE_NOEXCEPT __attribute__ ((__noreturn__));
+  void terminate() _GLIBCXX_USE_NOEXCEPT __attribute__ ((__noreturn__,__cold__));
 
 #if __cplusplus < 201703L || (__cplusplus <= 202002L && _GLIBCXX_USE_DEPRECATED)
   /// If you write a replacement %unexpected handler, it must be of this type.
@@ -104,7 +104,7 @@ namespace std _GLIBCXX_VISIBILITY(default)
    * @deprecated Removed from the C++ standard in C++17
    */
   _GLIBCXX11_DEPRECATED
-  void unexpected() __attribute__ ((__noreturn__));
+  void unexpected() __attribute__ ((__noreturn__,__cold__));
 #endif
 
   /** [18.6.4]/1:  'Returns true after completing evaluation of a

                 reply	other threads:[~2023-06-28  9:47 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230628094727.D756F3858D35@sourceware.org \
    --to=hubicka@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    --cc=libstdc++-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).