* [PATCH] testsuite: Require thread-fence for 29_atomics/atomic_flag/cons/value_init.cc
@ 2023-09-26 14:40 Hans-Peter Nilsson
2023-09-26 15:20 ` Jeff Law
0 siblings, 1 reply; 2+ messages in thread
From: Hans-Peter Nilsson @ 2023-09-26 14:40 UTC (permalink / raw)
To: gcc-patches, libstdc++
Ok to commit?
-- >8 --
A recent patch made __atomic_test_and_set no longer fall
back to emitting non-atomic code, but instead will then emit
a call to __atomic_test_and_set, thereby exposing the need
to gate also this test on support for atomics, similar to
r14-3980-g62b29347c38394.
libstdc++-v3:
* testsuite/29_atomics/atomic_flag/cons/value_init.cc: Add
dg-require-thread-fence.
---
libstdc++-v3/testsuite/29_atomics/atomic_flag/cons/value_init.cc | 1 +
1 file changed, 1 insertion(+)
diff --git a/libstdc++-v3/testsuite/29_atomics/atomic_flag/cons/value_init.cc b/libstdc++-v3/testsuite/29_atomics/atomic_flag/cons/value_init.cc
index 084e2930f7e2..f3f38b54dbcd 100644
--- a/libstdc++-v3/testsuite/29_atomics/atomic_flag/cons/value_init.cc
+++ b/libstdc++-v3/testsuite/29_atomics/atomic_flag/cons/value_init.cc
@@ -16,6 +16,7 @@
// <http://www.gnu.org/licenses/>.
// { dg-do run { target c++20 } }
+// { dg-require-thread-fence "" }
#include <atomic>
#include <testsuite_hooks.h>
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] testsuite: Require thread-fence for 29_atomics/atomic_flag/cons/value_init.cc
2023-09-26 14:40 [PATCH] testsuite: Require thread-fence for 29_atomics/atomic_flag/cons/value_init.cc Hans-Peter Nilsson
@ 2023-09-26 15:20 ` Jeff Law
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Law @ 2023-09-26 15:20 UTC (permalink / raw)
To: Hans-Peter Nilsson, gcc-patches, libstdc++
On 9/26/23 08:40, Hans-Peter Nilsson wrote:
> Ok to commit?
> -- >8 --
> A recent patch made __atomic_test_and_set no longer fall
> back to emitting non-atomic code, but instead will then emit
> a call to __atomic_test_and_set, thereby exposing the need
> to gate also this test on support for atomics, similar to
> r14-3980-g62b29347c38394.
>
> libstdc++-v3:
> * testsuite/29_atomics/atomic_flag/cons/value_init.cc: Add
> dg-require-thread-fence.
OK.
Jeff
ps. Missed you at the Cauldron....
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-09-26 15:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-26 14:40 [PATCH] testsuite: Require thread-fence for 29_atomics/atomic_flag/cons/value_init.cc Hans-Peter Nilsson
2023-09-26 15:20 ` Jeff Law
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).