From: "François Dumont" <frs.dumont@gmail.com>
To: "libstdc++@gcc.gnu.org" <libstdc++@gcc.gnu.org>
Subject: Re: [PATCH][_Hashtable] Fix insertion of range of type convertible to value_type PR 56112
Date: Wed, 18 May 2022 19:39:53 +0200 [thread overview]
Message-ID: <1f41b3cc-218b-ee0e-be93-63a2629dd7a1@gmail.com> (raw)
In-Reply-To: <ad6bab04-8de7-d58b-64d4-c80923d7a4b0@gmail.com>
Still no chance to validate ?
On 11/05/22 19:03, François Dumont wrote:
> Gentle reminder !
>
> On 05/05/22 19:37, François Dumont wrote:
>> Hi
>>
>> Renewing my patch to fix PR 56112 but for the insert methods, I
>> totally change it, now works also with move-only key types.
>>
>> I let you Jonathan find a better name than _ValueTypeEnforcer as
>> usual :-)
>>
>> libstdc++: [_Hashtable] Insert range of types convertible to
>> value_type PR 56112
>>
>> Fix insertion of range of types convertible to value_type. Fix also
>> when this value_type
>> has a move-only key_type which also allow converted values to be moved.
>>
>> libstdc++-v3/ChangeLog:
>>
>> PR libstdc++/56112
>> * include/bits/hashtable_policy.h (_ValueTypeEnforcer): New.
>> * include/bits/hashtable.h
>> (_Hashtable<>::_M_insert_unique_aux): New.
>> (_Hashtable<>::_M_insert(_Arg&&, const _NodeGenerator&,
>> true_type)): Use latters.
>> (_Hashtable<>::_M_insert(_Arg&&, const _NodeGenerator&,
>> false_type)): Likewise.
>> (_Hashtable(_InputIterator, _InputIterator, size_type, const
>> _Hash&, const _Equal&,
>> const allocator_type&, true_type)): Use this.insert range.
>> (_Hashtable(_InputIterator, _InputIterator, size_type, const
>> _Hash&, const _Equal&,
>> const allocator_type&, false_type)): Use _M_insert.
>> * testsuite/23_containers/unordered_map/cons/56112.cc: Check
>> how many times conversion
>> is done.
>> (test02): New test case.
>> * testsuite/23_containers/unordered_set/cons/56112.cc: New test.
>>
>> Tested under Linux x86_64.
>>
>> Ok to commit ?
>>
>> François
>>
>
next prev parent reply other threads:[~2022-05-18 17:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-15 9:05 François Dumont
2022-02-21 17:59 ` François Dumont
2022-02-21 20:54 ` Jonathan Wakely
2022-02-21 21:33 ` François Dumont
2022-05-05 17:37 ` François Dumont
2022-05-11 17:03 ` François Dumont
2022-05-18 17:39 ` François Dumont [this message]
2022-05-24 10:18 ` Jonathan Wakely
2022-05-24 10:22 ` Jonathan Wakely
2022-05-24 10:31 ` Jonathan Wakely
2022-05-25 5:09 ` [PATCH][_Hashtable] Fix insertion of range of type convertible to value_type PR 105714 François Dumont
2022-06-07 19:50 ` François Dumont
2022-06-14 21:53 ` Jonathan Wakely
2022-05-24 20:25 ` [PATCH][_Hashtable] Fix insertion of range of type convertible to value_type PR 56112 François Dumont
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f41b3cc-218b-ee0e-be93-63a2629dd7a1@gmail.com \
--to=frs.dumont@gmail.com \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).