public inbox for libstdc++@gcc.gnu.org
 help / color / mirror / Atom feed
From: "François Dumont" <frs.dumont@gmail.com>
To: "libstdc++@gcc.gnu.org" <libstdc++@gcc.gnu.org>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH][_Hashtable] Fix insertion of range of type convertible to value_type PR 56112
Date: Mon, 21 Feb 2022 18:59:11 +0100	[thread overview]
Message-ID: <87a6c4e2-9ba6-0c04-274a-5f204efe5d17@gmail.com> (raw)
In-Reply-To: <2fe3937d-1b9a-a547-bb41-225d3d5426a2@gmail.com>

Gentle reminder, it is important to have this for gcc 12.

On 15/02/22 10:05, François Dumont wrote:
> We have a regression regarding management of types convertible to 
> value_type. It is an occurrence of PR 56112 but for the insert method.
>
>     libstdc++: [_Hashtable] Insert range of types convertible to 
> value_type PR 56112
>
>     Fix insertion of range of types convertible to value_type.
>
>     libstdc++-v3/ChangeLog:
>
>             PR libstdc++/56112
>             * include/bits/hashtable.h
>             (_Hashtable<>::_M_insert_unique_aux): New.
>             (_Hashtable<>::_S_to_value): New.
>             (_Hashtable<>::_M_insert(_Arg&&, const _NodeGenerator&, 
> true_type)): Use latters.
>             * testsuite/23_containers/unordered_map/cons/56112.cc: Use 
> dg-do compile.
>             * testsuite/23_containers/unordered_set/cons/56112.cc: New 
> test.
>
> Tested under Linux x86_64.
>
> Ok to commit ?
>
> François



  reply	other threads:[~2022-02-21 17:59 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-15  9:05 François Dumont
2022-02-21 17:59 ` François Dumont [this message]
2022-02-21 20:54   ` Jonathan Wakely
2022-02-21 21:33     ` François Dumont
2022-05-05 17:37 ` François Dumont
2022-05-11 17:03   ` François Dumont
2022-05-18 17:39     ` François Dumont
2022-05-24 10:18   ` Jonathan Wakely
2022-05-24 10:22     ` Jonathan Wakely
2022-05-24 10:31       ` Jonathan Wakely
2022-05-25  5:09         ` [PATCH][_Hashtable] Fix insertion of range of type convertible to value_type PR 105714 François Dumont
2022-06-07 19:50           ` François Dumont
2022-06-14 21:53           ` Jonathan Wakely
2022-05-24 20:25     ` [PATCH][_Hashtable] Fix insertion of range of type convertible to value_type PR 56112 François Dumont

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a6c4e2-9ba6-0c04-274a-5f204efe5d17@gmail.com \
    --to=frs.dumont@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=libstdc++@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).