public inbox for libstdc++@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@redhat.com>
To: Jonathan Wakely <jwakely@redhat.com>
Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: Re: [committed] libstdc++: Suppress pedantic warnings about __int128
Date: Fri, 16 Jul 2021 10:27:09 +0200	[thread overview]
Message-ID: <20210716082709.GD2380545@tucnak> (raw)
In-Reply-To: <YPE4Eh0zTAT/8bZt@redhat.com>

On Fri, Jul 16, 2021 at 08:41:06AM +0100, Jonathan Wakely via Gcc-patches wrote:
> --- a/libstdc++-v3/include/bits/max_size_type.h
> +++ b/libstdc++-v3/include/bits/max_size_type.h
> @@ -417,7 +417,10 @@ namespace ranges
>  #endif
>  
>  #if __SIZEOF_INT128__
> +#pragma GCC diagnostic push
> +#pragma GCC diagnostic ignored "-Wpedantic"
>        using __rep = unsigned __int128;
> +#pragma GCC diagnostic pop

At least in simple cases like this, wouldn't
	using __rep = __extension__ unsigned __int128;
be smaller?  And it should be more targetted, wouldn't disable
other pedantic warnings but about __int128.

	Jakub


  reply	other threads:[~2021-07-16  8:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-16  7:41 Jonathan Wakely
2021-07-16  8:27 ` Jakub Jelinek [this message]
2021-07-16  8:29   ` Jakub Jelinek
2021-07-16  8:38     ` Jonathan Wakely
2021-07-16  8:39       ` Jonathan Wakely
2021-07-16 11:29         ` Jonathan Wakely
2021-07-16 13:02           ` [PATCH] libstdc++: Use __extension__ instead of diagnostic pragmas (was: Suppress pedantic warnings about __int128) Jonathan Wakely
2021-07-16 14:39             ` Jonathan Wakely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210716082709.GD2380545@tucnak \
    --to=jakub@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jwakely@redhat.com \
    --cc=libstdc++@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).