From: whh8b@obs.cr
To: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: [PATCH] libstdc++: Optimize operator+(string/char*, string/char*) equally
Date: Mon, 22 Aug 2022 14:15:08 -0400 [thread overview]
Message-ID: <20220822181509.1032874-1-whh8b@obs.cr> (raw)
After consultation with Jonathan, we realized that there was a missed
optimization opportunity in the implementation of the various forms of
operator+ for string.
operator+(char *, string) required a single allocation but
operator+(string, char*) required two. This patch attempts to change that
asymmetry.
Again, I have been a longtime reader of the source code but this patch is one of
my first attempts at contributing. I have attempted to follow all the rules but
I am sure that I missed something. Please let me know if/how I can change the
patch to make it acceptable.
Thanks for all your hard work maintaing this vital piece of software!
Will
next reply other threads:[~2022-08-22 18:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-22 18:15 whh8b [this message]
2022-08-22 18:15 ` whh8b
2022-08-23 16:33 ` Jonathan Wakely
2022-08-24 6:18 ` Will Hawkins
2022-08-24 9:49 ` Jonathan Wakely
2022-08-24 6:16 ` [PATCH v2] libstdc++: Optimize operator+(string/char*,string/char*) whh8b
2022-08-24 6:16 ` [PATCH] libstdc++: Optimize operator+(string/char*,string/char*) equally whh8b
2022-08-24 6:16 ` [PATCH] libstdc++: Optimize operator+(string/char*, string/char*) equally whh8b
2022-08-24 14:24 ` Jonathan Wakely
2022-08-24 22:39 ` Alexandre Oliva
2022-08-24 22:47 ` Jonathan Wakely
2022-08-24 23:02 ` Jonathan Wakely
2022-08-25 5:52 ` Will Hawkins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220822181509.1032874-1-whh8b@obs.cr \
--to=whh8b@obs.cr \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).