From: "Björn Schäpers" <gcc@hazardy.de>
To: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org, frs.dumont@gmail.com
Subject: [PATCH] libstdc++: Deliver names of C functions in <stacktrace>
Date: Tue, 13 Dec 2022 22:02:47 +0100 [thread overview]
Message-ID: <20221213210247.50375-1-gcc@hazardy.de> (raw)
In-Reply-To: <7973b22e-791b-a61e-e354-3e6f02e5a731@gmail.com>
From: Björn Schäpers <bjoern@hazardy.de>
One could add (), these are not part of __name. One could also try to
check upfront if __cxa_demangle should be called at all.
-- >8 --
Tested on i686-w64-mingw32.
__cxa_demangle is only to demangle C++ names, for all C functions,
extern "C" functions, and including main it returns -2, in that case
just adapt the given name. Otherwise it's kept empty, which doesn't look
nice in the stacktrace.
libstdc++-v3/ChangeLog:
* include/std/stacktrace (stacktrace_entry::_S_demangle): Use
raw __name if __cxa_demangle could not demangle it.
Signed-off-by: Björn Schäpers <bjoern@hazardy.de>
---
libstdc++-v3/include/std/stacktrace | 2 ++
1 file changed, 2 insertions(+)
diff --git a/libstdc++-v3/include/std/stacktrace b/libstdc++-v3/include/std/stacktrace
index 83c6463b0d8..5baf2dcdaca 100644
--- a/libstdc++-v3/include/std/stacktrace
+++ b/libstdc++-v3/include/std/stacktrace
@@ -219,6 +219,8 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
&__status);
if (__status == 0)
__s = __str;
+ else
+ __s = __name;
__builtin_free(__str);
return __s;
}
--
2.38.1
next prev parent reply other threads:[~2022-12-13 21:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-12 17:56 Björn Schäpers
2022-12-12 21:35 ` François Dumont
2022-12-13 21:02 ` Björn Schäpers [this message]
2023-01-14 20:37 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221213210247.50375-1-gcc@hazardy.de \
--to=gcc@hazardy.de \
--cc=frs.dumont@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).