From: Jonathan Wakely <jwakely@redhat.com>
To: "Björn Schäpers" <gcc@hazardy.de>
Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org, frs.dumont@gmail.com
Subject: Re: [PATCH] libstdc++: Deliver names of C functions in <stacktrace>
Date: Sat, 14 Jan 2023 20:37:29 +0000 [thread overview]
Message-ID: <CACb0b4mN4Ac6Np2r9kreG3Af=kh=F0nQJ3YruFfMDmBcuW78BQ@mail.gmail.com> (raw)
In-Reply-To: <20221213210247.50375-1-gcc@hazardy.de>
On Tue, 13 Dec 2022 at 21:03, Björn Schäpers <gcc@hazardy.de> wrote:
>
> From: Björn Schäpers <bjoern@hazardy.de>
>
> One could add (), these are not part of __name. One could also try to
> check upfront if __cxa_demangle should be called at all.
Thanks for the patch, I'll push this.
I think we do want to check whether to call __cxa_demangle, because
otherwise an extern "C" function called simply "g" will get demangled
to "__float128" and that's not right!
So I think we should check whether the function name starts with "_Z"
which indicates a C++ function name. That can be improved later
though.
>
> -- >8 --
>
> Tested on i686-w64-mingw32.
>
> __cxa_demangle is only to demangle C++ names, for all C functions,
> extern "C" functions, and including main it returns -2, in that case
> just adapt the given name. Otherwise it's kept empty, which doesn't look
> nice in the stacktrace.
>
> libstdc++-v3/ChangeLog:
>
> * include/std/stacktrace (stacktrace_entry::_S_demangle): Use
> raw __name if __cxa_demangle could not demangle it.
>
> Signed-off-by: Björn Schäpers <bjoern@hazardy.de>
> ---
> libstdc++-v3/include/std/stacktrace | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/libstdc++-v3/include/std/stacktrace b/libstdc++-v3/include/std/stacktrace
> index 83c6463b0d8..5baf2dcdaca 100644
> --- a/libstdc++-v3/include/std/stacktrace
> +++ b/libstdc++-v3/include/std/stacktrace
> @@ -219,6 +219,8 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
> &__status);
> if (__status == 0)
> __s = __str;
> + else
> + __s = __name;
> __builtin_free(__str);
> return __s;
> }
> --
> 2.38.1
>
prev parent reply other threads:[~2023-01-14 20:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-12 17:56 Björn Schäpers
2022-12-12 21:35 ` François Dumont
2022-12-13 21:02 ` Björn Schäpers
2023-01-14 20:37 ` Jonathan Wakely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACb0b4mN4Ac6Np2r9kreG3Af=kh=F0nQJ3YruFfMDmBcuW78BQ@mail.gmail.com' \
--to=jwakely@redhat.com \
--cc=frs.dumont@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gcc@hazardy.de \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).