From: Hans-Peter Nilsson <hp@axis.com>
To: <libstdc++@gcc.gnu.org>, <gcc-patches@gcc.gnu.org>
Subject: [PATCH] libstdc++ testsuite: Correct S0 in std/time/hh_mm_ss/1.cc
Date: Wed, 1 Feb 2023 15:38:31 +0100 [thread overview]
Message-ID: <20230201143831.BDA3A20423@pchp3.se.axis.com> (raw)
Tested cris-elf and native x86_64-pc-linux-gnu.
Ok to commit?
-----8< ------
For targets where the ABI mandates structure layout that has
no padding, like cris-elf, this test started failing when
introduced as an add-on to the existing 1.cc, thereby
effectively causing a regression in testsuite results.
Adding an empty structure to S0, corresponds better to the
layout of hh_mm_ss<seconds>.
PR testsuite/108632
* testsuite/std/time/hh_mm_ss/1.cc (size): Add empty
struct at end of S0.
---
libstdc++-v3/testsuite/std/time/hh_mm_ss/1.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libstdc++-v3/testsuite/std/time/hh_mm_ss/1.cc b/libstdc++-v3/testsuite/std/time/hh_mm_ss/1.cc
index d97a9057f472..26a4555576c8 100644
--- a/libstdc++-v3/testsuite/std/time/hh_mm_ss/1.cc
+++ b/libstdc++-v3/testsuite/std/time/hh_mm_ss/1.cc
@@ -103,7 +103,7 @@ size()
{
using namespace std::chrono;
- struct S0 { long long h; char m; char s; bool neg; };
+ struct S0 { long long h; char m; char s; bool neg; struct { } empty; };
static_assert(sizeof(hh_mm_ss<seconds>) == sizeof(S0));
struct S1 { long long h; char m; char s; bool neg; char ss; };
static_assert(sizeof(hh_mm_ss<duration<int, std::centi>>) == sizeof(S1));
--
2.30.2
next reply other threads:[~2023-02-01 14:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-01 14:38 Hans-Peter Nilsson [this message]
2023-02-01 16:01 ` Jonathan Wakely
2023-02-01 17:19 ` Jonathan Wakely
2023-02-01 22:37 ` Hans-Peter Nilsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230201143831.BDA3A20423@pchp3.se.axis.com \
--to=hp@axis.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).