From: Hans-Peter Nilsson <hp@axis.com>
To: Jonathan Wakely <jwakely@redhat.com>
Cc: <libstdc++@gcc.gnu.org>, <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] libstdc++ testsuite: Correct S0 in std/time/hh_mm_ss/1.cc
Date: Wed, 1 Feb 2023 23:37:00 +0100 [thread overview]
Message-ID: <20230201223700.85A2720430@pchp3.se.axis.com> (raw)
In-Reply-To: <CACb0b4kMUb299O=OjQ2z1TmOurqbq7C6TsWGy9WdbHxyv31bhg@mail.gmail.com> (message from Jonathan Wakely on Wed, 1 Feb 2023 18:19:09 +0100)
> From: Jonathan Wakely <jwakely@redhat.com>
> Date: Wed, 1 Feb 2023 18:19:09 +0100
> On Wed, 1 Feb 2023 at 16:01, Jonathan Wakely wrote:
> >
> > On Wed, 1 Feb 2023 at 14:38, Hans-Peter Nilsson via Libstdc++
> > <libstdc++@gcc.gnu.org> wrote:
> > >
> > > Tested cris-elf and native x86_64-pc-linux-gnu.
> > > Ok to commit?
> >
> > OK, thanks.
>
> We could add the [[no_unique_address]] attribute to the _M_ss member,
> so that it takes no space when it's an empty struct.
>
> That would save a byte in hh_mm_ss for cris-elf and targets like that,
> but as this type isn't meant to be used for storage, I don't think we
> should bother. People shouldn't be using this as a data member, just
> creating it on the stack and then discarding it.
>
Agreed; no worries. Thanks for the review.
brgds, H-P
prev parent reply other threads:[~2023-02-01 22:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-01 14:38 Hans-Peter Nilsson
2023-02-01 16:01 ` Jonathan Wakely
2023-02-01 17:19 ` Jonathan Wakely
2023-02-01 22:37 ` Hans-Peter Nilsson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230201223700.85A2720430@pchp3.se.axis.com \
--to=hp@axis.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jwakely@redhat.com \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).