public inbox for
 help / color / mirror / Atom feed
* [committed] libstdc++: Remove reliance on unspecified behaviour in std::rethrow_if_nested test
@ 2023-08-21  9:46 Jonathan Wakely
  0 siblings, 0 replies; only message in thread
From: Jonathan Wakely @ 2023-08-21  9:46 UTC (permalink / raw)
  To: libstdc++, gcc-patches; +Cc: Iain Sandoe

This is the patch resolving the non-portable test that Iain raised in:

Tested x86_64-linux. Pushed to trunk.

Backports would be OK, but I don't think they are needed.

-- >8 --

This test case calls std::set_terminate while there is an active
exception. Since LWG 2111 it is unspecified which terminate handler is
used when std::nested_exception::rethrow_nested() calls std::terminate.
With libsupc++ the global handler changed by std::set_terminate is used,
but libc++abi uses the active exception's handler (the one that was
current when the exception was first thrown).

Adjust the test case so that it works with either implementation choice.
So that the process doesn't exit cleanly if std::terminate happens
sooner than expected, use a global variable to control when the "clean
terminate" behaviour happens.


	* testsuite/18_support/nested_exception/
	Call std::set_terminate before throwing the nested exception.
 .../nested_exception/     | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/libstdc++-v3/testsuite/18_support/nested_exception/ b/libstdc++-v3/testsuite/18_support/nested_exception/
index 3bfc7ab9943..b221eea3178 100644
--- a/libstdc++-v3/testsuite/18_support/nested_exception/
+++ b/libstdc++-v3/testsuite/18_support/nested_exception/
@@ -4,25 +4,33 @@
 #include <exception>
 #include <cstdlib>
-[[noreturn]] void terminate_cleanly() noexcept { std::exit(0); }
+int exit_status = 1;
+[[noreturn]] void terminate_cleanly() noexcept { std::exit(exit_status); }
 struct A { virtual ~A() = default; };
 int main()
+  std::set_terminate(terminate_cleanly);
     // At this point std::current_exception() == nullptr so the
     // std::nested_exception object is empty.
+    // Should not reach this point.
+    std::abort();
   catch (const A& a)
-    std::set_terminate(terminate_cleanly);
+    // This means the expected std::terminate() call will exit cleanly,
+    // so this test will PASS.
+    exit_status = 0;
 #if __cpp_rtti
     // No nested exception, so trying to rethrow it calls std::terminate()
-    // which calls std::exit(0). Shoud not reach this point.
+    // which calls std::exit(0). Should not reach this point.
     // Without RTTI we can't dynamic_cast<const std::nested_exception*>(&a)

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-08-21  9:47 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-21  9:46 [committed] libstdc++: Remove reliance on unspecified behaviour in std::rethrow_if_nested test Jonathan Wakely

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).