From: "Paul M. Bendixen" <paulbendixen@gmail.com>
To: "Arsen Arsenović" <arsen@aarsen.me>
Cc: Jonathan Wakely <jwakely@redhat.com>,
libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] libstdc++ Add cstdarg to freestanding
Date: Wed, 16 Aug 2023 18:50:33 +0200 [thread overview]
Message-ID: <CAAvei9rt67_z2Uaz=jKHJokUs1cJ_nFYqCgWK6a3Mz0-Q_qFxA@mail.gmail.com> (raw)
In-Reply-To: <86leeb9jtz.fsf@aarsen.me>
[-- Attachment #1: Type: text/plain, Size: 2423 bytes --]
Yes, the other files are in another committee proposal, and I'm working my
way through the proposals one by one.
Thank you for the feedback, I'll update and resend
/Paul
Den ons. 16. aug. 2023 kl. 15.51 skrev Arsen Arsenović <arsen@aarsen.me>:
>
> Jonathan Wakely <jwakely@redhat.com> writes:
>
> > On Fri, 21 Jul 2023 at 22:23, Paul M. Bendixen via Libstdc++
> > <libstdc++@gcc.gnu.org> wrote:
> >>
> >> P1642 includes the header cstdarg to the freestanding implementation.
> >> This was probably left out by accident, this patch puts it in.
> >> Since this is one of the headers that go in whole cloth, there should
> be no
> >> further actions needed.
> >
> > Thanks for the patch. I agree that <cstdarg> should be freestanding,
> > but I think <cstdalign> and <cstdbool> were also missed from the
> > change. Arsen?
>
> Indeed, we should include all three, and according to [compliance],
> there's a couple more headers that we should provide (cwchar, cstring,
> cerrno, and cmath, but these are probably significantly more involved,
> so we can handle them separately).
>
> As guessed, the omission was not intentional.
>
> If you could, add those two to the patch as well, edit Makefile.am and
> regenerate using automake 1.15.1, and see
> https://gcc.gnu.org/contribute.html wrt. changelogs in commit messages.
>
> Thank you! Have a lovely day :-)
>
> [compliance]: https://eel.is/c++draft/compliance
>
> > Also, the patch should change include/Makefile.am as well (the .in
> > file is autogenerated from that one).
> >
> >
> >> This might be related to PR106953, but since that one touches the
> partial
> >> headers I'm not sure
>
> The headers mentioned in this PR are provided in freestanding,
> partially, in 13 already, indeed.
>
> >> /Paul M. Bendixen
> >>
> >> --
> >> • − − •/• −/• • −/• − • •/− • • •/•/− •/− • •/• •/− • • −/•/− •/• − − •−
> >> •/− − •/− −/• −/• •/• − • •/• − • − • −/− • − •/− − −/− −//
>
>
> --
> Arsen Arsenović
>
--
• − − •/• −/• • −/• − • •/− • • •/•/− •/− • •/• •/− • • −/•/− •/• − − •−
•/− − •/− −/• −/• •/• − • •/• − • − • −/− • − •/− − −/− −//
next prev parent reply other threads:[~2023-08-16 16:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 21:22 Paul M. Bendixen
2023-08-16 11:21 ` Jonathan Wakely
2023-08-16 13:27 ` Arsen Arsenović
2023-08-16 16:50 ` Paul M. Bendixen [this message]
2023-08-18 19:14 ` Paul M. Bendixen
2023-09-07 16:28 ` Jonathan Wakely
2023-10-20 20:55 ` Paul M. Bendixen
2023-10-22 20:06 ` Arsen Arsenović
2023-10-24 20:27 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAvei9rt67_z2Uaz=jKHJokUs1cJ_nFYqCgWK6a3Mz0-Q_qFxA@mail.gmail.com' \
--to=paulbendixen@gmail.com \
--cc=arsen@aarsen.me \
--cc=gcc-patches@gcc.gnu.org \
--cc=jwakely@redhat.com \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).