From: Jonathan Wakely <jwakely@redhat.com>
To: Alexandre Oliva <oliva@gnu.org>
Cc: "libstdc++" <libstdc++@gcc.gnu.org>,
gcc Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] libstdc++-v3: check for openat
Date: Tue, 28 Jun 2022 14:12:58 +0100 [thread overview]
Message-ID: <CACb0b4=+mv1WgJ6Niab8nactzgkkJ=miYL61UiZTW1F+jA4F3A@mail.gmail.com> (raw)
In-Reply-To: <or5yklxad2.fsf@lxoliva.fsfla.org>
On Tue, 28 Jun 2022 at 13:04, Alexandre Oliva <oliva@gnu.org> wrote:
>
> On Jun 28, 2022, Jonathan Wakely <jwakely@redhat.com> wrote:
>
> > I'll push this today.
>
> Thanks!
>
> > You can just use --enable-libstdcxx-debug
>
> Thanks again ;-)
>
> > Again, that test is *supposed* to return without creating the
> > destination. It's testing the failure case.
>
> Aha, and that's why one shouldn't debug something without looking at the
> code to see what it's *supposed* to do ;-)
>
> >> FAILED: default@libstdc++,27_io,filesystem,operations,copy_cc
> >> FAILED: default@libstdc++,experimental,filesystem,operations,copy_cc
> >>
> >> .../27_io/filesystem/operations/copy.cc:5[67]: void test01():
> >> Assertion '!exists(to)' failed.
>
> > I don't know what 5[67] means
>
> Sorry for being unclear, it's just that the corresponding failing
> asserts are at different lines in the two mentioned testcases, and I
> tried to convey that fact with regexp notation.
Doh! Of course. I thought it was some rtems thing. /facepalm
>
> > Which suggests to me another problem with mkstemp / nonexistent_path.
>
> *lightbulb powers up*
>
> Now it all makes sense.
>
> It isn't *another* problem, that probably regressed when the mkstemp
> patch went in and so it got out of my radar and thus out of the patchset
> I used in subsequent test runs, but because of the way I use the testing
> system, the baseline on top of which the patchset was installed was
> still was still that of the previous nightly build, so I effectively
> dropped the mkstemp fix. And since when I joined this project this bug
> had already been fixed, I didn't associate the regressions with the
> patch.
Makes sense.
> Apologies for the noise. Today's baseline, plus your _At_path patch and
> my remove_all patch, is all clear. Yay!
Great!
next prev parent reply other threads:[~2022-06-28 13:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-22 6:41 Alexandre Oliva
2022-06-22 10:36 ` Jonathan Wakely
2022-06-23 4:41 ` Alexandre Oliva
2022-06-23 9:29 ` Jonathan Wakely
2022-06-23 11:08 ` Alexandre Oliva
2022-06-23 11:37 ` Jonathan Wakely
2022-06-23 14:05 ` Alexandre Oliva
2022-06-23 17:47 ` Jonathan Wakely
2022-06-27 12:00 ` Alexandre Oliva
2022-06-27 13:05 ` Alexandre Oliva
2022-06-27 13:32 ` Jonathan Wakely
2022-06-27 14:00 ` Jonathan Wakely
2022-06-27 15:56 ` Jonathan Wakely
2022-06-27 22:03 ` Alexandre Oliva
2022-06-28 8:36 ` Jonathan Wakely
2022-06-28 12:04 ` Alexandre Oliva
2022-06-28 13:12 ` Jonathan Wakely [this message]
2022-06-24 11:03 ` Jonathan Wakely
2022-06-27 9:49 ` Alexandre Oliva
2022-06-27 9:52 ` Jonathan Wakely
2022-06-24 2:34 ` Alexandre Oliva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACb0b4=+mv1WgJ6Niab8nactzgkkJ=miYL61UiZTW1F+jA4F3A@mail.gmail.com' \
--to=jwakely@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
--cc=oliva@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).