From: Alexandre Oliva <oliva@adacore.com>
To: Jonathan Wakely <jwakely@redhat.com>
Cc: gcc Patches <gcc-patches@gcc.gnu.org>,
"libstdc++" <libstdc++@gcc.gnu.org>
Subject: Re: [PATCH] libstdc++-v3: check for openat
Date: Thu, 23 Jun 2022 11:05:35 -0300 [thread overview]
Message-ID: <or4k0b326o.fsf@lxoliva.fsfla.org> (raw)
In-Reply-To: <CACb0b4=CE=WZuDSr4E1g=oDU7e4WgK6ENUG4M5QUrAbYhdUnjQ@mail.gmail.com> (Jonathan Wakely's message of "Thu, 23 Jun 2022 12:37:44 +0100")
On Jun 23, 2022, Jonathan Wakely <jwakely@redhat.com> wrote:
> On Thu, 23 Jun 2022 at 12:08, Alexandre Oliva <oliva@adacore.com> wrote:
>>
>> On Jun 22, 2022, Jonathan Wakely <jwakely@redhat.com> wrote:
>>
>> > There are other interactions between AT_CDCWD and ::openat not covered
>> > by this patch. I this this also needs to check HAVE_OPENAT:
>>
>> Here's an updated version, tested with this additional change.
> Did this improve your test results for directory iterators?
'fraid the bad results I posted earlier today had this patch in. I
can't tell whether it improved anything because I didn't save earlier
results to compare.
> In the unlikely even that the target has ::unlinkat but not ::openat
c++config.h on the target says:
/* #undef _GLIBCXX_HAVE_UNLINKAT */
Thanks for the concern,
--
Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/
Free Software Activist GNU Toolchain Engineer
Disinformation flourishes because many people care deeply about injustice
but very few check the facts. Ask me about <https://stallmansupport.org>
next prev parent reply other threads:[~2022-06-23 14:05 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-22 6:41 Alexandre Oliva
2022-06-22 10:36 ` Jonathan Wakely
2022-06-23 4:41 ` Alexandre Oliva
2022-06-23 9:29 ` Jonathan Wakely
2022-06-23 11:08 ` Alexandre Oliva
2022-06-23 11:37 ` Jonathan Wakely
2022-06-23 14:05 ` Alexandre Oliva [this message]
2022-06-23 17:47 ` Jonathan Wakely
2022-06-27 12:00 ` Alexandre Oliva
2022-06-27 13:05 ` Alexandre Oliva
2022-06-27 13:32 ` Jonathan Wakely
2022-06-27 14:00 ` Jonathan Wakely
2022-06-27 15:56 ` Jonathan Wakely
2022-06-27 22:03 ` Alexandre Oliva
2022-06-28 8:36 ` Jonathan Wakely
2022-06-28 12:04 ` Alexandre Oliva
2022-06-28 13:12 ` Jonathan Wakely
2022-06-24 11:03 ` Jonathan Wakely
2022-06-27 9:49 ` Alexandre Oliva
2022-06-27 9:52 ` Jonathan Wakely
2022-06-24 2:34 ` Alexandre Oliva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=or4k0b326o.fsf@lxoliva.fsfla.org \
--to=oliva@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jwakely@redhat.com \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).