From: Jonathan Wakely <jwakely@redhat.com>
To: Thomas Rodgers <trodgers@redhat.com>
Cc: "libstdc++" <libstdc++@gcc.gnu.org>,
gcc Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] libstdc++: Split up pstl/set.cc testcase
Date: Tue, 4 Jul 2023 00:15:52 +0100 [thread overview]
Message-ID: <CACb0b4=BGrs7XE9_g6DOv90tXt0CVEqweHTkkdenyVw_aQkURg@mail.gmail.com> (raw)
In-Reply-To: <CAMmuTO_-n_We6J1k_OXeZAKja9B+7DwkjTrOX6g8NB1ziJWYVg@mail.gmail.com>
On Mon, 3 Jul 2023 at 23:14, Thomas Rodgers via Libstdc++
<libstdc++@gcc.gnu.org> wrote:
>
> This testcase is causing some timeout issues. This patch splits the
> testcase up by individual set algorithm.
I think the Apache license requires a notice saying the original file
was modified. A comment in each new file noting it was derived from
pstl/alg_sorting/set.cc (or whatever the file is called upstream)
should be sufficient.
OK with that change, thanks.
next prev parent reply other threads:[~2023-07-03 23:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-03 22:13 Thomas Rodgers
2023-07-03 23:15 ` Jonathan Wakely [this message]
2023-07-05 22:06 ` Thomas Rodgers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACb0b4=BGrs7XE9_g6DOv90tXt0CVEqweHTkkdenyVw_aQkURg@mail.gmail.com' \
--to=jwakely@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
--cc=trodgers@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).