From: Thomas Rodgers <trodgers@redhat.com>
To: Jonathan Wakely <jwakely@redhat.com>
Cc: "libstdc++" <libstdc++@gcc.gnu.org>,
gcc Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] libstdc++: Split up pstl/set.cc testcase
Date: Wed, 5 Jul 2023 15:06:33 -0700 [thread overview]
Message-ID: <CAMmuTO9Lg1SzUZAgOSu__eJ6jXVtUiiAn1MFmAeuUNuSBFwMWg@mail.gmail.com> (raw)
In-Reply-To: <CACb0b4=BGrs7XE9_g6DOv90tXt0CVEqweHTkkdenyVw_aQkURg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 653 bytes --]
Comment added to each file.
Tested x86_64-linux. Pushed to trunk.
On Mon, Jul 3, 2023 at 4:16 PM Jonathan Wakely <jwakely@redhat.com> wrote:
> On Mon, 3 Jul 2023 at 23:14, Thomas Rodgers via Libstdc++
> <libstdc++@gcc.gnu.org> wrote:
> >
> > This testcase is causing some timeout issues. This patch splits the
> > testcase up by individual set algorithm.
>
> I think the Apache license requires a notice saying the original file
> was modified. A comment in each new file noting it was derived from
> pstl/alg_sorting/set.cc (or whatever the file is called upstream)
> should be sufficient.
>
> OK with that change, thanks.
>
>
prev parent reply other threads:[~2023-07-05 22:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-03 22:13 Thomas Rodgers
2023-07-03 23:15 ` Jonathan Wakely
2023-07-05 22:06 ` Thomas Rodgers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMmuTO9Lg1SzUZAgOSu__eJ6jXVtUiiAn1MFmAeuUNuSBFwMWg@mail.gmail.com \
--to=trodgers@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jwakely@redhat.com \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).