From: Jonathan Wakely <jwakely@redhat.com>
To: "François Dumont" <frs.dumont@gmail.com>
Cc: "libstdc++" <libstdc++@gcc.gnu.org>
Subject: Re: std::experimental and versioned namespace
Date: Tue, 19 Sep 2023 09:03:58 +0100 [thread overview]
Message-ID: <CACb0b4=DfFoFoNCxDWH98SSvdDyZsCoaLNW6HFMYPgRFNaa82g@mail.gmail.com> (raw)
In-Reply-To: <9e60d796-b675-1190-a795-349bd308933a@gmail.com>
On Tue, 19 Sept 2023 at 06:10, François Dumont via Libstdc++
<libstdc++@gcc.gnu.org> wrote:
>
> I'm running 'make check-c++' in gnu-versioned_namespace mode and among
> all the failures are those:
>
> compiler exited with status 1
> FAIL: g++.dg/contracts/contracts-access1.C (test for excess errors)
> Excess errors:
> contracts-access1.C:(.text._ZN4Base1bEv.pre[_ZN4Base1bEv]+0x64):
> undefined reference to
> `handle_contract_violation(std::experimental::contract_violation const&)'
The <experimental/contract> header uses the versioned namespace macros
for the contract_violation type:
namespace std _GLIBCXX_VISIBILITY(default)
{
_GLIBCXX_BEGIN_NAMESPACE_VERSION
namespace experimental
{
But the compiler expects it to be in the std::experimental namespace.
> I still need to find out what's going wrong but I also wonder if we need
> to use the versioned namespace for things in std::experimental namespace
> ? Those are already abi unstable, no ?
Yes, we can just remove the VERSION macros from the header.
next prev parent reply other threads:[~2023-09-19 8:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-19 5:10 François Dumont
2023-09-19 8:03 ` Jonathan Wakely [this message]
2023-09-20 4:54 ` François Dumont
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACb0b4=DfFoFoNCxDWH98SSvdDyZsCoaLNW6HFMYPgRFNaa82g@mail.gmail.com' \
--to=jwakely@redhat.com \
--cc=frs.dumont@gmail.com \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).